Skip to content

Commit ff57087

Browse files
srabinovdavem330
authored andcommitted
rds: debug messages are enabled by default
rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages. This option cause the rds Makefile to add -DDEBUG to the rds gcc command line. When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by include/linux/dynamic_debug.h to decide if dynamic debug prints should be sent by default to the kernel log. rds should not enable this macro for production builds. rds dynamic debug work as expected follow this fix. Signed-off-by: Shamir Rabinovitch <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Reviewed-by: Wengang Wang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 880b583 commit ff57087

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

net/rds/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ obj-$(CONFIG_RDS_TCP) += rds_tcp.o
1313
rds_tcp-y := tcp.o tcp_connect.o tcp_listen.o tcp_recv.o \
1414
tcp_send.o tcp_stats.o
1515

16-
ccflags-$(CONFIG_RDS_DEBUG) := -DDEBUG
16+
ccflags-$(CONFIG_RDS_DEBUG) := -DRDS_DEBUG
1717

net/rds/rds.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#define KERNEL_HAS_ATOMIC64
3434
#endif
3535

36-
#ifdef DEBUG
36+
#ifdef RDS_DEBUG
3737
#define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args)
3838
#else
3939
/* sigh, pr_debug() causes unused variable warnings */

0 commit comments

Comments
 (0)