Skip to content

Commit ff815fb

Browse files
Alexander DuyckJeff Kirsher
authored andcommitted
ixgbe: There is no need to update num_rx_pools in L2 fwd offload
The num_rx_pools value is overwritten when we reinitialize the queue configuration. In reality we shouldn't need to be updating the value since it is redone every time we call into ixgbe_setup_tc so for now just drop the spots where we were incrementing or decrementing the value. Signed-off-by: Alexander Duyck <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 2af62c5 commit ff815fb

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ static void ixgbe_set_num_queues(struct ixgbe_adapter *adapter)
701701
adapter->num_rx_queues = 1;
702702
adapter->num_tx_queues = 1;
703703
adapter->num_xdp_queues = 0;
704-
adapter->num_rx_pools = adapter->num_rx_queues;
704+
adapter->num_rx_pools = 1;
705705
adapter->num_rx_queues_per_pool = 1;
706706

707707
#ifdef CONFIG_IXGBE_DCB

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9843,7 +9843,6 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)
98439843
return ERR_PTR(-ENOMEM);
98449844

98459845
pool = find_first_zero_bit(&adapter->fwd_bitmask, 32);
9846-
adapter->num_rx_pools++;
98479846
set_bit(pool, &adapter->fwd_bitmask);
98489847
limit = find_last_bit(&adapter->fwd_bitmask, 32);
98499848

@@ -9872,7 +9871,6 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)
98729871
netdev_info(pdev,
98739872
"%s: dfwd hardware acceleration failed\n", vdev->name);
98749873
clear_bit(pool, &adapter->fwd_bitmask);
9875-
adapter->num_rx_pools--;
98769874
kfree(fwd_adapter);
98779875
return ERR_PTR(err);
98789876
}
@@ -9884,7 +9882,6 @@ static void ixgbe_fwd_del(struct net_device *pdev, void *priv)
98849882
unsigned int limit;
98859883

98869884
clear_bit(fwd_adapter->pool, &adapter->fwd_bitmask);
9887-
adapter->num_rx_pools--;
98889885

98899886
limit = find_last_bit(&adapter->fwd_bitmask, 32);
98909887
adapter->ring_feature[RING_F_VMDQ].limit = limit + 1;

0 commit comments

Comments
 (0)