Skip to content

Commit fff6e6a

Browse files
edumazetdavem330
authored andcommitted
ipv6: anycast: use call_rcu_hurry() in aca_put()
This is a followup of commit b5327b9 ("ipv6: use call_rcu_hurry() in fib6_info_release()"). I had another pmtu.sh failure, and found another lazy call_rcu() causing this failure. aca_free_rcu() calls fib6_info_release() which releases devices references. We must not delay it too much or risk unregister_netdevice/ref_tracker traces because references to netdev are not released in time. This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: David Ahern <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c2e6a87 commit fff6e6a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

net/ipv6/anycast.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,8 @@ static void aca_free_rcu(struct rcu_head *h)
252252

253253
static void aca_put(struct ifacaddr6 *ac)
254254
{
255-
if (refcount_dec_and_test(&ac->aca_refcnt)) {
256-
call_rcu(&ac->rcu, aca_free_rcu);
257-
}
255+
if (refcount_dec_and_test(&ac->aca_refcnt))
256+
call_rcu_hurry(&ac->rcu, aca_free_rcu);
258257
}
259258

260259
static struct ifacaddr6 *aca_alloc(struct fib6_info *f6i,

0 commit comments

Comments
 (0)