add global tunable for navigate window

fixes #2397

Author: Vladimir Kotal

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Configuration.java

@@ -274,6 +274,12 @@ public final class Configuration {
      */
     private boolean listDirsFirst = true;
 
+    /**
+     * A flag if the navigate window should be opened by default when browsing
+     * the source code of projects.
+     */
+    private boolean navigateWindowEnabled;
+
     private SuggesterConfig suggesterConfig = new SuggesterConfig();
 
     /*
@@ -441,6 +447,7 @@ public Configuration() {
         //mandoc is default(String)
         setMaxSearchThreadCount(2 * Runtime.getRuntime().availableProcessors());
         setMessageLimit(500);
+        setNavigateWindowEnabled(false);
         setOptimizeDatabase(true);
         setPluginDirectory(null);
         setPluginStack(new AuthorizationStack(AuthControlFlag.REQUIRED, "default stack"));
@@ -727,6 +734,14 @@ public void setHandleHistoryOfRenamedFiles(boolean enable) {
         this.handleHistoryOfRenamedFiles = enable;
     }
 
+    public boolean isNavigateWindowEnabled() {
+        return navigateWindowEnabled;
+    }
+
+    public void setNavigateWindowEnabled(boolean navigateWindowEnabled) {
+        this.navigateWindowEnabled = navigateWindowEnabled;
+    }
+
     public Map<String,Project> getProjects() {
         return projects;
     }

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Project.java

@@ -66,7 +66,7 @@ public class Project implements Comparable<Project>, Nameable, Serializable {
      * A flag if the navigate window should be opened by default when browsing
      * the source code of this project.
      */
-    private boolean navigateWindowEnabled = false;
+    private Boolean navigateWindowEnabled = null;
 
     /**
      * This flag sets per-project handling of renamed files.
@@ -227,7 +227,7 @@ public boolean hasTabSizeSetting() {
      * @return true if yes; false otherwise
      */
     public boolean isNavigateWindowEnabled() {
-        return navigateWindowEnabled;
+        return navigateWindowEnabled != null && navigateWindowEnabled;
     }
 
     /**
@@ -326,6 +326,11 @@ final public void completeWithDefaults(Configuration cfg) {
         if (historyEnabled == null) {
             setHistoryEnabled(cfg.isHistoryEnabled());
         }
+
+        // Allow project to override global setting of navigate window.
+        if (navigateWindowEnabled == null) {
+            setNavigateWindowEnabled(cfg.isNavigateWindowEnabled());
+        }
     }
 
     /**

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/RuntimeEnvironment.java

@@ -1182,6 +1182,14 @@ public boolean isHandleHistoryOfRenamedFiles() {
         return threadConfig.get().isHandleHistoryOfRenamedFiles();
     }
 
+    public void setNavigateWindowEnabled(boolean enable) {
+        threadConfig.get().setNavigateWindowEnabled(enable);
+    }
+
+    public boolean isNavigateWindowEnabled() {
+        return threadConfig.get().isNavigateWindowEnabled();
+    }
+
     public void setRevisionMessageCollapseThreshold(int threshold) {
         threadConfig.get().setRevisionMessageCollapseThreshold(threshold);
     }

opengrok-indexer/src/test/java/org/opengrok/indexer/configuration/ProjectTest.java

@@ -140,13 +140,15 @@ public void testGetProjectDescriptions() {
     public void testMergeProjects1() {
         Configuration cfg = new Configuration();
         cfg.setTabSize(new Configuration().getTabSize() + 3731);
+        cfg.setNavigateWindowEnabled(!new Configuration().isNavigateWindowEnabled());
 
         Project p1 = new Project();
+        assertNotNull(p1);
 
         p1.completeWithDefaults(cfg);
 
-        assertNotNull(p1);
-        assertEquals(new Configuration().getTabSize() + 3731, p1.getTabSize());
+        assertEquals(cfg.getTabSize(), p1.getTabSize());
+        assertEquals(cfg.isNavigateWindowEnabled(), p1.isNavigateWindowEnabled());
     }
 
     /**