Fixed stepExecution injection into readers

Author: gquemener

Entity/StepExecution.php

@@ -488,6 +488,18 @@ function ($e) {
         );
     }
 
+    public function addError($message)
+    {
+        $this->errors[] = $message;
+
+        return $this;
+    }
+
+    public function getErrors()
+    {
+        return $this->errors;
+    }
+
     /**
      * To string
      * @return string

Item/Support/ArrayReader.php

@@ -29,7 +29,7 @@ public function setItems(array $items)
     /**
      * {@inheritdoc}
      */
-    public function read(StepExecution $stepExecution)
+    public function read()
     {
         $item = null;
 

Tests/Unit/EventListener/LoggerSubscriberTest.php

@@ -178,10 +178,8 @@ public function testInvalidReaderExecution()
             ->expects($this->once())
             ->method('warning')
             ->with(
-                $this->matchesRegularExpression(
-                    '/^The .+ was unable to handle the following data: \[foo => bar\] '.
-                    '\(REASON: This is a valid reason\.\)\.$/'
-                )
+                'The Oro\Bundle\BatchBundle\Item\ItemReaderInterface was unable ' .
+                'to handle the following data: [foo => bar] (REASON: This is a valid reason.).'
             );
 
         $stepExecution = $this->getStepExecutionMock();
@@ -191,7 +189,7 @@ public function testInvalidReaderExecution()
                 $this->returnValue(
                     array(
                         array(
-                            'reader' => $this->getMock('Oro\Bundle\BatchBundle\Item\ItemReaderInterface'),
+                            'reader' => 'Oro\Bundle\BatchBundle\Item\ItemReaderInterface',
                             'reason' => 'This is a valid reason.',
                             'data' => array('foo' => 'bar'),
                         )
@@ -209,10 +207,8 @@ public function testDoNotLogTwiceTheSameInvalidReaderExecution()
             ->expects($this->once())
             ->method('warning')
             ->with(
-                $this->matchesRegularExpression(
-                    '/^The .+ was unable to handle the following data: \[foo => bar\] '.
-                    '\(REASON: This is a valid reason\.\)\.$/'
-                )
+                'The Oro\Bundle\BatchBundle\Item\ItemReaderInterface was unable ' .
+                'to handle the following data: [foo => bar] (REASON: This is a valid reason.).'
             );
 
         $stepExecution = $this->getStepExecutionMock();
@@ -222,7 +218,7 @@ public function testDoNotLogTwiceTheSameInvalidReaderExecution()
                 $this->returnValue(
                     array(
                         array(
-                            'reader' => $this->getMock('Oro\Bundle\BatchBundle\Item\ItemReaderInterface'),
+                            'reader' => 'Oro\Bundle\BatchBundle\Item\ItemReaderInterface',
                             'reason' => 'This is a valid reason.',
                             'data' => array('foo' => 'bar'),
                         )

Tests/Unit/Step/Stub/ReaderStub.php

@@ -11,7 +11,7 @@ class ReaderStub implements ItemReaderInterface, StepExecutionAwareInterface
     /**
      * {@inheritDoc}
      */
-    public function read(StepExecution $stepExecution)
+    public function read()
     {
     }