Factorized the warning handling method

Author: gquemener

Step/ItemStep.php

@@ -176,17 +176,7 @@ public function doExecute(StepExecution $stepExecution)
                     continue;
                 }
             } catch (InvalidItemException $e) {
-                $stepExecution->addError(
-                    get_class($this->reader),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
-
-                $this->dispatchInvalidItemEvent(
-                    get_class($this->reader),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
+                $this->handleStepExecutionWarning($stepExecution, get_class($this->reader), $e);
 
                 continue;
             }
@@ -203,17 +193,7 @@ public function doExecute(StepExecution $stepExecution)
                     );
                 }
             } catch (InvalidItemException $e) {
-                $stepExecution->addError(
-                    get_class($this->processor),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
-
-                $this->dispatchInvalidItemEvent(
-                    get_class($this->processor),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
+                $this->handleStepExecutionWarning($stepExecution, get_class($this->processor), $e);
 
                 continue;
             }
@@ -225,17 +205,7 @@ public function doExecute(StepExecution $stepExecution)
                     $this->writer->write($itemsToWrite);
                     $itemsToWrite = array();
                 } catch (InvalidItemException $e) {
-                    $stepExecution->addError(
-                        get_class($this->writer),
-                        $e->getMessage(),
-                        $e->getItem()
-                    );
-
-                    $this->dispatchInvalidItemEvent(
-                        get_class($this->processor),
-                        $e->getMessage(),
-                        $e->getItem()
-                    );
+                    $this->handleStepExecutionWarning($stepExecution, get_class($this->writer), $e);
 
                     continue;
                 }
@@ -247,17 +217,7 @@ public function doExecute(StepExecution $stepExecution)
                 $this->writer->write($itemsToWrite);
                 $itemsToWrite = array();
             } catch (InvalidItemException $e) {
-                $stepExecution->addError(
-                    get_class($this->writer),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
-
-                $this->dispatchInvalidItemEvent(
-                    get_class($this->processor),
-                    $e->getMessage(),
-                    $e->getItem()
-                );
+                $this->handleStepExecutionWarning($stepExecution, get_class($this->writer), $e);
             }
         }
     }
@@ -279,4 +239,17 @@ protected function initializeStepComponents(StepExecution $stepExecution)
             $this->writer->setStepExecution($stepExecution);
         }
     }
+
+    /**
+     * Handle step execution warning
+     *
+     * @param StepExecution        $stepExecution
+     * @param string               $class
+     * @param InvalidItemException $e
+     */
+    private function handleStepExecutionWarning(StepExecution $stepExecution, $class, InvalidItemException $e)
+    {
+        $stepExecution->addError($class, $e->getMessage(), $e->getItem());
+        $this->dispatchInvalidItemEvent($class, $e->getMessage(), $e->getItem());
+    }
 }