Skip to content

Commit 24a1f52

Browse files
committed
PackageManager: Added more detailed errors messages on load methods
1 parent e15d09b commit 24a1f52

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/client/javascript/core/package-manager.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,9 @@
9292
var len = Object.keys(packages).length;
9393
if ( len ) {
9494
cb();
95-
return;
95+
} else {
96+
callback(false, API._('ERR_PACKAGE_ENUM_FAILED'), PackageManager);
9697
}
97-
98-
callback(false, 'No packages found!', PackageManager);
9998
});
10099
}
101100

@@ -173,7 +172,7 @@
173172
var uri = API.getConfig('Connection.MetadataURI');
174173
Utils.preload([uri], function(total, failed) {
175174
if ( failed.length ) {
176-
callback('Failed to load package manifest', failed);
175+
callback(API._('ERR_PACKAGE_MANIFEST'), failed);
177176
return;
178177
}
179178

src/client/javascript/locales/en_EN.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,8 @@
304304
//
305305

306306
'ERR_PACKAGE_EXISTS': 'Package installation directory already exists. Cannot continue!',
307+
'ERR_PACKAGE_MANIFEST': 'Failed to load package manifest',
308+
'ERR_PACKAGE_ENUM_FAILED': 'Failed to get package list. Make sure you\'re not using "Private Mode" as this might case problems.',
307309

308310
//
309311
// DefaultApplication

0 commit comments

Comments
 (0)