Skip to content

Commit 2052545

Browse files
committed
Make deserializer interface private
I'd like to avoid people using this for the time being.
1 parent 20e9cfc commit 2052545

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

decoder.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (d *decoder) decode(offset uint, result reflect.Value, depth int) (uint, er
5656
return d.decodeFromType(typeNum, size, newOffset, result, depth+1)
5757
}
5858

59-
func (d *decoder) decodeToDeserializer(offset uint, dser Deserializer, depth int) (uint, error) {
59+
func (d *decoder) decodeToDeserializer(offset uint, dser deserializer, depth int) (uint, error) {
6060
if depth > maximumDataStructureDepth {
6161
return 0, newInvalidDatabaseError("exceeded maximum data structure depth; database is likely corrupt")
6262
}
@@ -173,7 +173,7 @@ func (d *decoder) decodeFromTypeToDeserializer(
173173
dtype dataType,
174174
size uint,
175175
offset uint,
176-
dser Deserializer,
176+
dser deserializer,
177177
depth int,
178178
) (uint, error) {
179179
// For these types, size has a special meaning
@@ -564,7 +564,7 @@ func (d *decoder) decodeMap(
564564
func (d *decoder) decodeMapToDeserializer(
565565
size uint,
566566
offset uint,
567-
dser Deserializer,
567+
dser deserializer,
568568
depth int,
569569
) (uint, error) {
570570
err := dser.StartMap(size)
@@ -645,7 +645,7 @@ func (d *decoder) decodeSlice(
645645
func (d *decoder) decodeSliceToDeserializer(
646646
size uint,
647647
offset uint,
648-
dser Deserializer,
648+
dser deserializer,
649649
depth int,
650650
) (uint, error) {
651651
err := dser.StartSlice(size)

deserializer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package maxminddb
22

33
import "math/big"
44

5-
// Deserializer is an interface for a type that deserializes an MaxMind DB
5+
// deserializer is an interface for a type that deserializes an MaxMind DB
66
// data record to some other type. This exists as an alternative to the
77
// standard reflection API.
88
//
@@ -13,7 +13,7 @@ import "math/big"
1313
// This interface and the associated unmarshaling code is EXPERIMENTAL!
1414
// It is not currently covered by any Semantic Versioning guarantees.
1515
// Use at your own risk.
16-
type Deserializer interface {
16+
type deserializer interface {
1717
StartSlice(uint) error
1818
StartMap(uint) error
1919
End() error

reader.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ func (r *Reader) decode(offset uintptr, result interface{}) error {
227227
return errors.New("result param must be a pointer")
228228
}
229229

230-
if dser, ok := result.(Deserializer); ok {
230+
if dser, ok := result.(deserializer); ok {
231231
_, err := r.decoder.decodeToDeserializer(uint(offset), dser, 0)
232232
return err
233233
}

0 commit comments

Comments
 (0)