Skip to content

Commit 6a69cca

Browse files
nightlyoneoschwald
authored andcommitted
Add appengine build tags for windows (#35)
When you run the local simulation of an appengine on windows, the mmap_windows.go variant is selected, which requiring an import of unsafe. Since unsafe is forbidden on appengine, we get an compile time error message looking like this: The Go application could not be built. (Executed command: C:\go_appengine\goroot\bin\go-app-builder.exe -app_base C:\goroot\src<redacted>\appentry -arch 6 -dynamic -goroot C:\go_appengine\goroot -nobuild_files ^^$ -unsafe -gopath C:\goroot\ -print_extras_hash main.go) 2016/12/05 11:39:12 go-app-builder: Failed parsing input: parser: bad import "unsafe" in github.com\oschwald\maxminddb-golang\decoder.go from GOPATH So we fix this by putting an explicit build tag which excludes appengine on windows there.
1 parent 2af0544 commit 6a69cca

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

mmap_windows.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// +build windows,!appengine
2+
13
package maxminddb
24

35
// Windows support largely borrowed from mmap-go.

0 commit comments

Comments
 (0)