Skip to content

Commit da01570

Browse files
committed
Fix broken test
I don't think this test would have ever worked.
1 parent a33c0e0 commit da01570

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

reader_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,10 @@ func TestValueTypeInterface(t *testing.T) {
363363

364364
reader, err := Open(testFile("MaxMind-DB-test-decoder.mmdb"))
365365
require.NoError(t, err)
366-
require.NoError(t, reader.Lookup(net.ParseIP("::1.1.1.0"), &result))
367366

368-
assert.Equal(t, true, result.Boolean.true())
367+
// although it would be nice to support cases like this, I am not sure it
368+
// is possible to do so in a general way.
369+
assert.Error(t, reader.Lookup(net.ParseIP("::1.1.1.0"), &result))
369370
}
370371

371372
type NestedMapX struct {

0 commit comments

Comments
 (0)