Skip to content

build folder is not a library #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamza-hajji opened this issue Dec 20, 2017 · 1 comment
Open

build folder is not a library #2

hamza-hajji opened this issue Dec 20, 2017 · 1 comment

Comments

@hamza-hajji
Copy link

I install the necessary libraries and everything works ok, but it's not working as expected.

My config-overrides.js

const rewireCreateReactLibrary = require('react-app-rewire-react-library');

module.exports = function override(config, env) {
  config = rewireCreateReactLibrary(config, env);
  return config;
};

My package.json

{
  "name": "todo-app",
  "module": "./src/index.js",
  "main": "./build/main.js",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "bootstrap": "^4.0.0-beta.2",
    "font-awesome": "^4.7.0",
    "lodash": "^4.17.4",
    "marked": "^0.3.7",
    "material-design-icons": "^3.0.1",
    "react": "^16.2.0",
    "react-dom": "^16.2.0",
    "react-redux": "^5.0.6",
    "react-scripts": "1.0.17",
    "redux": "^3.7.2",
    "slate": "^0.31.7",
    "slate-html-serializer": "^0.4.15",
    "slate-react": "^0.10.22",
    "uuid": "^3.1.0"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-app-rewired build",
    "test": "react-scripts test --env=jsdom",
    "eject": "react-scripts eject",
    "deploy": "npm run build && surge -p=build -d todolist-redux.surge.sh",
    "build-library": "react-app-rewired build --library"
  },
  "devDependencies": {
    "react-app-rewire-react-library": "^0.1.1",
    "react-app-rewired": "^1.4.0"
  }
}

When I run yarn run build-library, this is the folder content I get
image

Which are exactly the files I get when I run yarn run build.

@osdevisnot
Copy link
Owner

@hamza-hajji strange, do you get another folder called dist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants