Skip to content

Commit e59cfbc

Browse files
committed
[benchmark] LogParser: Accept - in bench. names
Extend parser to support benchmark names that include `-` in names, as proposed in PR swiftlang#20334.
1 parent 1e7b28a commit e59cfbc

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

benchmark/scripts/compare_perf_tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,9 @@ def _reset(self):
363363
# Parse lines like this
364364
# #,TEST,SAMPLES,MIN(μs),MAX(μs),MEAN(μs),SD(μs),MEDIAN(μs)
365365
results_re = re.compile(
366-
r'( *\d+[, \t]+[\w.]+[, \t]+' + # #,TEST
367-
r'[, \t]+'.join([r'\d+'] * 2) + # at least 2...
368-
r'(?:[, \t]+\d*)*)') # ...or more numeric columns
366+
r'( *\d+[, \t]+[\w.\-]+[, \t]+' + # #,TEST
367+
r'[, \t]+'.join([r'\d+'] * 2) + # at least 2...
368+
r'(?:[, \t]+\d*)*)') # ...or more numeric columns
369369

370370
def _append_result(self, result):
371371
columns = result.split(',') if ',' in result else result.split()

benchmark/scripts/test_compare_perf_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,14 +445,15 @@ class TestLogParser(unittest.TestCase):
445445
def test_parse_results_csv(self):
446446
"""Ignores uknown lines, extracts data from supported formats."""
447447
log = """#,TEST,SAMPLES,MIN(us),MAX(us),MEAN(us),SD(us),MEDIAN(us)
448-
34,BitCount,20,3,4,4,0,4
448+
34,Flatten.Array.Tuple4.lazy.for-in.Reserve,20,3,4,4,0,4
449449
450450
Total performance tests executed: 1
451451
"""
452452
parser = LogParser()
453453
results = parser.parse_results(log.splitlines())
454454
self.assertTrue(isinstance(results[0], PerformanceTestResult))
455-
self.assertEquals(results[0].name, 'BitCount')
455+
self.assertEquals(results[0].name,
456+
'Flatten.Array.Tuple4.lazy.for-in.Reserve')
456457

457458
def test_parse_results_tab_delimited(self):
458459
log = '34\tBitCount\t20\t3\t4\t4\t0\t4'

0 commit comments

Comments
 (0)