Skip to content

Commit 1740d03

Browse files
jbrockmendeljreback
authored andcommitted
REF: get_value do less inside try (#30835)
1 parent 77fd1cf commit 1740d03

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pandas/core/indexes/datetimes.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ def get_value(self, series, key):
657657
return series.take(locs)
658658

659659
try:
660-
return com.maybe_box(self, Index.get_value(self, series, key), series, key)
660+
value = Index.get_value(self, series, key)
661661
except KeyError:
662662
try:
663663
loc = self._get_string_slice(key)
@@ -669,6 +669,8 @@ def get_value(self, series, key):
669669
return self.get_value_maybe_box(series, key)
670670
except (TypeError, ValueError, KeyError):
671671
raise KeyError(key)
672+
else:
673+
return com.maybe_box(self, value, series, key)
672674

673675
def get_value_maybe_box(self, series, key):
674676
# needed to localize naive datetimes

pandas/core/indexes/period.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ def get_value(self, series, key):
509509
"""
510510
s = com.values_from_object(series)
511511
try:
512-
return com.maybe_box(self, super().get_value(s, key), series, key)
512+
value = super().get_value(s, key)
513513
except (KeyError, IndexError):
514514
if isinstance(key, str):
515515
asdt, parsed, reso = parse_time_string(key, self.freq)
@@ -541,6 +541,8 @@ def get_value(self, series, key):
541541
period = Period(key, self.freq)
542542
key = period.value if isna(period) else period.ordinal
543543
return com.maybe_box(self, self._int64index.get_value(s, key), series, key)
544+
else:
545+
return com.maybe_box(self, value, series, key)
544546

545547
@Appender(_index_shared_docs["get_indexer"] % _index_doc_kwargs)
546548
def get_indexer(self, target, method=None, limit=None, tolerance=None):

0 commit comments

Comments
 (0)