cleanups

Author: topper-123

pandas/_testing/asserters.py

@@ -266,9 +266,9 @@ def assert_index_equal(
     left : Index
     right : Index
     exact : bool or {'equiv'}, default 'equiv'
-        It True, check that the Index class, dtype and inferred_type are identical.
-        If 'equiv', numeric indexes will only be compared by dtype and inferred_type.
-        It False, do not check that Index class, dtype and inferred_type are identical.
+        Whether to check the Index class, dtype and inferred_type
+        are identical. If 'equiv', then RangeIndex can be substituted for
+        Int64Index as well.
     check_names : bool, default True
         Whether to check the names attribute.
     check_less_precise : bool or int, default False

pandas/core/indexes/base.py

@@ -441,7 +441,7 @@ def __new__(
 
         # index-like
         elif isinstance(data, Index) and data._is_numeric_index and dtype is None:
-            return type(data)(data, name=name, copy=copy)
+            return data._constructor(data, name=name, copy=copy)
         elif isinstance(data, (np.ndarray, Index, ABCSeries)):
 
             if isinstance(data, ABCMultiIndex):
@@ -5726,7 +5726,7 @@ def map(self, mapper, na_action=None):
             attributes["dtype"] = self.dtype
 
         if self._is_numeric_index and is_numeric_dtype(new_values.dtype):
-            return type(self)(new_values, **attributes)
+            return self._constructor(new_values, **attributes)
 
         return Index(new_values, **attributes)
 

pandas/core/indexes/category.py

@@ -289,7 +289,7 @@ def astype(self, dtype, copy: bool = True) -> Index:
 
         categories = self.categories
         # the super method always returns Int64Index, UInt64Index and Float64Index
-        # but if e.g. the categories are a NumIndex with dtype float32, we want to
+        # but if the categories are a NumericIndex with dtype float32, we want to
         # return an index with the same dtype as self.categories.
         if categories._is_numeric_index:
             assert isinstance(categories, NumericIndex)  # mypy complaint fix
@@ -301,7 +301,7 @@ def astype(self, dtype, copy: bool = True) -> Index:
                 new_values = self._data.astype(dtype, copy=copy)
                 # pass copy=False because any copying has been done in the
                 #  _data.astype call above
-                return type(categories)(new_values, name=self.name, copy=False)
+                return categories._constructor(new_values, name=self.name, copy=False)
 
         return super().astype(dtype, copy=copy)
 

pandas/core/indexes/numeric.py

@@ -242,7 +242,7 @@ def astype(self, dtype, copy=True):
                     return NumericIndex(arr, name=self.name, dtype=dtype)
         elif self._is_numeric_index:
             if not is_extension_array_dtype(dtype) and is_numeric_dtype(dtype):
-                return type(self)(self, dtype=dtype, copy=copy)
+                return self._constructor(self, dtype=dtype, copy=copy)
 
         return super().astype(dtype, copy=copy)
 

pandas/tests/indexes/common.py

@@ -357,7 +357,7 @@ def test_numpy_argsort(self, index):
     def test_repeat(self, simple_index):
         rep = 2
         idx = simple_index.copy()
-        new_index_cls = type(idx) if not isinstance(idx, RangeIndex) else Int64Index
+        new_index_cls = Int64Index if isinstance(idx, RangeIndex) else idx._constructor
         expected = new_index_cls(idx.values.repeat(rep), name=idx.name)
         tm.assert_index_equal(idx.repeat(rep), expected)