Skip to content

Commit 55d62a1

Browse files
committed
Updated test_stata.py
1 parent 6bbd33d commit 55d62a1

File tree

1 file changed

+15
-24
lines changed

1 file changed

+15
-24
lines changed

pandas/tests/io/test_stata.py

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2591,35 +2591,26 @@ def test_many_strl(temp_file, version):
25912591

25922592
@pytest.mark.parametrize("version", [114, 117, 118, 119, None])
25932593
def test_convert_dates_key_handling(tmp_path, version):
2594-
# GH 60536
2594+
25952595
temp_file = tmp_path / "test.dta"
25962596
df = DataFrame({"old_name": [1, 2, 3], "some_other_name": [4, 5, 6]})
25972597

2598-
# Case 1: Key exists in _convert_dates
2598+
# Case 1: Key exists in convert_dates
25992599
convert_dates = {"old_name": "converted_date"}
2600-
df.rename(columns={"old_name": "new_name"}, inplace=True)
2601-
with StataWriter(
2602-
temp_file,
2603-
df,
2604-
convert_dates=convert_dates,
2605-
version=version,
2606-
) as writer:
2607-
writer.write_file()
2600+
df_renamed = df.rename(columns={"old_name": "new_name"}) # Mimic column renaming
2601+
df_renamed.to_stata(temp_file, convert_dates=convert_dates)
2602+
26082603
result = read_stata(temp_file)
2609-
assert list(result.columns) == ["new_name", "some_other_name"]
2610-
assert "converted_date" in result.columns
2604+
assert "new_name" in result.columns
2605+
assert "old_name" not in result.columns
2606+
assert result["new_name"].tolist() == ["converted_date", "converted_date", "converted_date"]
26112607

2612-
# Case 2: Key does not exist in _convert_dates
2613-
df = DataFrame({"old_name": [1, 2, 3], "some_other_name": [4, 5, 6]})
2608+
# Case 2: Key does not exist in convert_dates
26142609
convert_dates = {"some_other_name": "converted_date"}
2615-
df.rename(columns={"old_name": "new_name"}, inplace=True)
2616-
with StataWriter(
2617-
temp_file,
2618-
df,
2619-
convert_dates=convert_dates,
2620-
version=version,
2621-
) as writer:
2622-
writer.write_file()
2610+
df_renamed = df.rename(columns={"old_name": "new_name"}) # Mimic column renaming
2611+
df_renamed.to_stata(temp_file, convert_dates=convert_dates)
2612+
26232613
result = read_stata(temp_file)
2624-
assert list(result.columns) == ["new_name", "some_other_name"]
2625-
assert "converted_date" in result.columns
2614+
assert "new_name" not in result.columns
2615+
assert "old_name" in result.columns
2616+
assert result["some_other_name"].tolist() == ["converted_date", "converted_date", "converted_date"]

0 commit comments

Comments
 (0)