Skip to content

Commit 64c1c48

Browse files
committed
Add comment and release note
1 parent 862afd1 commit 64c1c48

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

doc/source/whatsnew/v1.0.0.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ I/O
205205
- Improve infinity parsing. :meth:`read_csv` now interprets ``Infinity``, ``+Infinity``, ``-Infinity`` as floating point values (:issue:`10065`)
206206
- Bug in :meth:`DataFrame.to_csv` where values were truncated when the length of ``na_rep`` was shorter than the text input data. (:issue:`25099`)
207207
- Bug in :func:`DataFrame.to_string` where values were truncated using display options instead of outputting the full content (:issue:`9784`)
208+
- Bug in :func:`DataFrame.to_parquet` where writing to GCS would fail with `engine='fastparquet'` if the file did not already exist (:issue:`28326`)
208209

209210
Plotting
210211
^^^^^^^^

pandas/io/parquet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,11 @@ def write(
160160
kwargs["file_scheme"] = "hive"
161161

162162
if is_s3_url(path) or is_gcs_url(path):
163-
# path is s3:// so we need to open the s3file in 'wb' mode.
163+
# if path is s3:// or gs:// we need to open the file in 'wb' mode.
164164
# TODO: Support 'ab'
165165

166166
path, _, _, _ = get_filepath_or_buffer(path, mode="wb")
167-
# And pass the opened s3file to the fastparquet internal impl.
167+
# And pass the opened file to the fastparquet internal impl.
168168
kwargs["open_with"] = lambda path, _: path
169169
else:
170170
path, _, _, _ = get_filepath_or_buffer(path)

0 commit comments

Comments
 (0)