make attribute name clearer

Author: topper-123

pandas/core/indexes/base.py

@@ -362,7 +362,7 @@ def _outer_indexer(
 
     # Whether this index is a NumericIndex, but not a Int64Index, Float64Index,
     # UInt64Index or RangeIndex. Needed for backwards compat. Remove in pandas 2.0.
-    _is_numeric_index: bool = False
+    _is_backward_compat_public_numeric_index: bool = False
 
     _engine_type: type[libindex.IndexEngine] = libindex.ObjectEngine
     # whether we support partial string indexing. Overridden
@@ -441,7 +441,11 @@ def __new__(
             return Index._simple_new(data, name=name)
 
         # index-like
-        elif isinstance(data, Index) and data._is_numeric_index and dtype is None:
+        elif (
+            isinstance(data, Index)
+            and data._is_backward_compat_public_numeric_index
+            and dtype is None
+        ):
             return data._constructor(data, name=name, copy=copy)
         elif isinstance(data, (np.ndarray, Index, ABCSeries)):
 
@@ -5726,7 +5730,9 @@ def map(self, mapper, na_action=None):
             # empty
             attributes["dtype"] = self.dtype
 
-        if self._is_numeric_index and is_numeric_dtype(new_values.dtype):
+        if self._is_backward_compat_public_numeric_index and is_numeric_dtype(
+            new_values.dtype
+        ):
             return self._constructor(new_values, **attributes)
 
         return Index(new_values, **attributes)

pandas/core/indexes/category.py

@@ -291,7 +291,7 @@ def astype(self, dtype, copy: bool = True) -> Index:
         # the super method always returns Int64Index, UInt64Index and Float64Index
         # but if the categories are a NumericIndex with dtype float32, we want to
         # return an index with the same dtype as self.categories.
-        if categories._is_numeric_index:
+        if categories._is_backward_compat_public_numeric_index:
             assert isinstance(categories, NumericIndex)  # mypy complaint fix
             try:
                 categories._validate_dtype(dtype)

pandas/core/indexes/numeric.py

@@ -97,7 +97,7 @@ class NumericIndex(Index):
     )
     _is_numeric_dtype = True
     _can_hold_strings = False
-    _is_numeric_index: bool = True
+    _is_backward_compat_public_numeric_index: bool = True
 
     @cache_readonly
     def _can_hold_na(self) -> bool:
@@ -206,9 +206,11 @@ def _ensure_dtype(cls, dtype: Dtype | None) -> np.dtype | None:
         dtype = pandas_dtype(dtype)
         assert isinstance(dtype, np.dtype)
 
-        if cls._is_numeric_index:  # NumericIndex
+        if cls._is_backward_compat_public_numeric_index:
+            # dtype for NumericIndex
             return dtype
-        else:  # Int64Index, UInt64Index etc.
+        else:
+            # dtype for Int64Index, UInt64Index etc. Needed for backwards compat.
             return cls._default_dtype
 
     def __contains__(self, key) -> bool:
@@ -244,7 +246,7 @@ def astype(self, dtype, copy=True):
                     return Int64Index(arr, name=self.name)
                 else:
                     return NumericIndex(arr, name=self.name, dtype=dtype)
-        elif self._is_numeric_index:
+        elif self._is_backward_compat_public_numeric_index:
             if not is_extension_array_dtype(dtype) and is_numeric_dtype(dtype):
                 return self._constructor(self, dtype=dtype, copy=copy)
 
@@ -356,7 +358,7 @@ class IntegerIndex(NumericIndex):
     This is an abstract class for Int64Index, UInt64Index.
     """
 
-    _is_numeric_index: bool = False
+    _is_backward_compat_public_numeric_index: bool = False
 
     @property
     def asi8(self) -> np.ndarray:
@@ -422,4 +424,4 @@ class Float64Index(NumericIndex):
     _engine_type = libindex.Float64Engine
     _default_dtype = np.dtype(np.float64)
     _dtype_validation_metadata = (is_float_dtype, "float")
-    _is_numeric_index: bool = False
+    _is_backward_compat_public_numeric_index: bool = False

pandas/core/indexes/range.py

@@ -101,7 +101,7 @@ class RangeIndex(NumericIndex):
     _engine_type = libindex.Int64Engine
     _dtype_validation_metadata = (is_signed_integer_dtype, "signed integer")
     _range: range
-    _is_numeric_index: bool = False
+    _is_backward_compat_public_numeric_index: bool = False
 
     # --------------------------------------------------------------------
     # Constructors

pandas/tests/base/test_unique.py

@@ -25,7 +25,7 @@ def test_unique(index_or_series_obj):
         expected = pd.MultiIndex.from_tuples(unique_values)
         expected.names = obj.names
         tm.assert_index_equal(result, expected, exact=True)
-    elif isinstance(obj, pd.Index) and obj._is_numeric_index:
+    elif isinstance(obj, pd.Index) and obj._is_backward_compat_public_numeric_index:
         expected = NumericIndex(unique_values, dtype=obj.dtype)
         tm.assert_index_equal(result, expected, exact=True)
     elif isinstance(obj, pd.Index):
@@ -66,7 +66,7 @@ def test_unique_null(null_obj, index_or_series_obj):
     unique_values_not_null = [val for val in unique_values_raw if not pd.isnull(val)]
     unique_values = [null_obj] + unique_values_not_null
 
-    if isinstance(obj, pd.Index) and obj._is_numeric_index:
+    if isinstance(obj, pd.Index) and obj._is_backward_compat_public_numeric_index:
         expected = NumericIndex(unique_values, dtype=obj.dtype)
         tm.assert_index_equal(result, expected, exact=True)
     elif isinstance(obj, pd.Index):

pandas/tests/indexes/common.py

@@ -666,7 +666,7 @@ def test_map_dictlike(self, mapper, simple_index):
         tm.assert_index_equal(result, expected)
 
         # empty mappable
-        if idx._is_numeric_index:
+        if idx._is_backward_compat_public_numeric_index:
             new_index_cls = NumericIndex
         else:
             new_index_cls = Float64Index

pandas/tests/indexes/test_any_index.py

@@ -51,7 +51,7 @@ def test_mutability(index):
 def test_map_identity_mapping(index):
     # GH#12766
     result = index.map(lambda x: x)
-    if index._is_numeric_index:
+    if index._is_backward_compat_public_numeric_index:
         if is_float_dtype(index.dtype):
             expected = index.astype(np.float64)
         elif index.dtype == np.uint64:

pandas/tests/indexes/test_base.py

@@ -714,7 +714,7 @@ def test_map_dictlike(self, index, mapper):
         if index.empty:
             # to match proper result coercion for uints
             expected = Index([])
-        elif index._is_numeric_index:
+        elif index._is_backward_compat_public_numeric_index:
             if is_float_dtype(index.dtype):
                 exp_dtype = np.float64
             else: