Skip to content

Commit 9e23c35

Browse files
misc clean
1 parent 71d1e6c commit 9e23c35

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

pandas/core/arrays/string_.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ def construct_from_string(cls, string):
138138
f"'construct_from_string' expects a string, got {type(string)}"
139139
)
140140
if string == "string":
141-
# TODO: use global default
142141
return cls()
143142
elif string == "string[python]":
144143
return cls(storage="python")

pandas/tests/arrays/string_/test_string.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,8 +460,7 @@ def test_arrow_roundtrip(dtype):
460460
table = pa.table(df)
461461
assert table.field("a").type == "string"
462462
result = table.to_pandas()
463-
if not isinstance(dtype, str):
464-
assert isinstance(result["a"].dtype, type(dtype))
463+
assert isinstance(result["a"].dtype, type(dtype))
465464
tm.assert_frame_equal(result, df)
466465
# ensure the missing value is represented by NA and not np.nan or None
467466
assert result.loc[2, "a"] is pd.NA

0 commit comments

Comments
 (0)