BUG: GH 4667 setitem error/dtype wrong with Series/Frame when setting with None

Author: jreback

doc/source/release.rst

@@ -285,6 +285,7 @@ See :ref:`Internal Refactoring<whatsnew_0130.refactoring>`
   - Fix an issue with CacheableOffset not properly being used by many DateOffset; this prevented
     the DateOffset from being cached (:issue:`4609`)
   - Fix boolean comparison with a DataFrame on the lhs, and a list/tuple on the rhs (:issue:`4576`)
+  - Fix error/dtype conversion with setitem of ``None`` on ``Series/DataFrame`` (:issue:`4667`)
 
 pandas 0.12
 ===========

pandas/core/internals.py

@@ -564,6 +564,10 @@ def putmask(self, mask, new, inplace=False):
             mask = mask.reindex_axis(
                 self.items, axis=axis, copy=False).values.T
 
+        # if we are passed a scalar None, convert it here
+        if not is_list_like(new) and isnull(new):
+            new = np.nan
+
         if self._can_hold_element(new):
             new = self._try_cast(new)
             np.putmask(new_values, mask, new)
@@ -578,7 +582,7 @@ def create_block(v, m, n, item, reshape=True):
                 """ return a new block, try to preserve dtype if possible """
 
                 # n should the length of the mask or a scalar here
-                if np.isscalar(n):
+                if not is_list_like(n):
                     n = np.array([n] * len(m))
 
                 # see if we are only masking values that if putted

pandas/tests/test_frame.py

@@ -7867,6 +7867,14 @@ def test_where_datetime(self):
         expected.loc[[0,1],'A'] = np.nan
         assert_frame_equal(result,expected)
 
+    def test_where_none(self):
+        # GH 4667
+        # setting with None changes dtype
+        df = DataFrame({'series': Series(range(10))}).astype(float)
+        df[df > 7] = None
+        expected = DataFrame({'series': Series([0,1,2,3,4,5,6,7,np.nan,np.nan]) })
+        assert_frame_equal(df, expected)
+
     def test_mask(self):
         df = DataFrame(np.random.randn(5, 3))
         cond = df > 0

pandas/tests/test_series.py

@@ -1249,6 +1249,19 @@ def f():
         expected = Series([np.nan,np.nan,3,4])
         assert_series_equal(result, expected)
 
+        # GH 4667
+        # setting with None changes dtype
+        s = Series(range(10)).astype(float)
+        s[8] = None
+        result = s[8]
+        self.assert_(isnull(result))
+
+        s = Series(range(10)).astype(float)
+        s[s > 8] = None
+        result = s[isnull(s)]
+        expected = Series(np.nan,index=[9])
+        assert_series_equal(result, expected)
+
     def test_where_broadcast(self):
         # Test a variety of differently sized series
         for size in range(2, 6):