👌 use pandas testing module to check for no warnings, dont ignore warnings, remove whatsnewentry

Author: Marco Gorelli

doc/source/whatsnew/v1.1.0.rst

@@ -168,7 +168,7 @@ I/O
 Plotting
 ^^^^^^^^
 
-- Plotting tz-aware timeseries no longer gives UserWarning (:issue:`31205`)
+-
 -
 
 Groupby/resample/rolling

pandas/plotting/_matplotlib/timeseries.py

@@ -1,7 +1,6 @@
 # TODO: Use the fact that axis can have units to simplify the process
 
 import functools
-import warnings
 
 import numpy as np
 
@@ -252,9 +251,7 @@ def _maybe_convert_index(ax, data):
         freq = frequencies.get_period_alias(freq)
 
         if isinstance(data.index, ABCDatetimeIndex):
-            with warnings.catch_warnings():
-                warnings.filterwarnings("ignore", category=UserWarning)
-                data = data.to_period(freq=freq)
+            data = data.tz_localize(None).to_period(freq=freq)
         elif isinstance(data.index, ABCPeriodIndex):
             data.index = data.index.asfreq(freq=freq)
     return data

pandas/tests/plotting/test_datetimelike.py

@@ -44,13 +44,13 @@ def teardown_method(self, method):
         tm.close()
 
     @pytest.mark.slow
-    def test_ts_plot_with_tz(self, tz_aware_fixture, recwarn):
+    def test_ts_plot_with_tz(self, tz_aware_fixture):
         # GH2877, GH17173, GH31205
         tz = tz_aware_fixture
         index = date_range("1/1/2011", periods=2, freq="H", tz=tz)
         ts = Series([188.5, 328.25], index=index)
-        _check_plot_works(ts.plot)
-        assert not any(isinstance(i.message, UserWarning) for i in recwarn)
+        with tm.assert_produces_warning(None):
+            _check_plot_works(ts.plot)
 
     def test_fontsize_set_correctly(self):
         # For issue #8765