add cleanups

Author: topper-123

pandas/__init__.py

@@ -76,7 +76,6 @@
     RangeIndex,
     Float64Index,
     MultiIndex,
-    NumericIndex,
     IntervalIndex,
     TimedeltaIndex,
     DatetimeIndex,

pandas/core/indexes/numeric.py

@@ -166,10 +166,11 @@ def _ensure_array(cls, data, dtype, copy: bool):
         dtype = cls._ensure_dtype(dtype)
 
         if copy or not is_dtype_equal(data.dtype, dtype):
-            subarr = np.array(data, dtype=dtype, copy=copy)
-            if not is_numeric_dtype(subarr.dtype):
-                # hack to raise correctly
-                subarr = np.array(data, dtype="float64", copy=copy)
+            try:
+                subarr = np.array(data, dtype=dtype, copy=copy)
+                cls._validate_dtype(subarr.dtype)
+            except (TypeError, ValueError):
+                raise ValueError(f"data is not compatible with {cls.__name__}")
             cls._assert_safe_casting(data, subarr)
         else:
             subarr = data

pandas/tests/indexes/common.py

@@ -33,8 +33,8 @@
     isna,
 )
 import pandas._testing as tm
+from pandas.core.api import NumericIndex
 from pandas.core.indexes.datetimelike import DatetimeIndexOpsMixin
-from pandas.core.indexes.numeric import NumericIndex
 
 
 class Base:

pandas/tests/indexes/numeric/test_numeric.py

@@ -128,10 +128,8 @@ def test_constructor_invalid(self):
         with pytest.raises((TypeError, ValueError), match=msg):
             index_cls(["a", "b", 0.0])
 
-        msg = (
-            r"float\(\) argument must be a string or a( real)? number, not 'Timestamp'"
-        )
-        with pytest.raises(TypeError, match=msg):
+        msg = f"data is not compatible with {index_cls.__name__}"
+        with pytest.raises(ValueError, match=msg):
             index_cls([Timestamp("20130101")])
 
     def test_constructor_coerce(self, mixed_index, float_index):

pandas/tests/indexes/test_numpy_compat.py

@@ -9,8 +9,8 @@
     TimedeltaIndex,
 )
 import pandas._testing as tm
+from pandas.core.api import NumericIndex
 from pandas.core.indexes.datetimelike import DatetimeIndexOpsMixin
-from pandas.core.indexes.numeric import NumericIndex
 
 
 @pytest.mark.parametrize(