Skip to content

Commit e69f9a1

Browse files
committed
Update as per comments
1 parent 51f5171 commit e69f9a1

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pandas/tests/io/test_gbq.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from datetime import datetime
33
import os
44
import platform
5+
import uuid
56

67
import numpy as np
78
import pytest
@@ -19,11 +20,6 @@
1920
PRIVATE_KEY_JSON_PATH = None
2021
PRIVATE_KEY_JSON_CONTENTS = None
2122

22-
DATASET_ID = "pydata_pandas_bq_testing_py3"
23-
24-
TABLE_ID = "new_test"
25-
DESTINATION_TABLE = f"{DATASET_ID + '1'}.{TABLE_ID}"
26-
2723
VERSION = platform.python_version()
2824

2925

@@ -156,8 +152,10 @@ def gbq_dataset(self):
156152
_skip_if_no_project_id()
157153
_skip_if_no_private_key_path()
158154

155+
dataset_id = "pydata_pandas_bq_testing_py31"
156+
159157
self.client = _get_client()
160-
self.dataset = self.client.dataset(DATASET_ID + "1")
158+
self.dataset = self.client.dataset(dataset_id)
161159
try:
162160
# Clean-up previous test runs.
163161
self.client.delete_dataset(self.dataset, delete_contents=True)
@@ -166,13 +164,15 @@ def gbq_dataset(self):
166164

167165
self.client.create_dataset(bigquery.Dataset(self.dataset))
168166

169-
yield
167+
table_id = str(uuid.uuid1())
168+
destination_table = f"{dataset_id}.{table_id}"
169+
yield destination_table
170170

171171
# Teardown Dataset
172172
self.client.delete_dataset(self.dataset, delete_contents=True)
173173

174174
def test_roundtrip(self, gbq_dataset):
175-
destination_table = DESTINATION_TABLE + "1"
175+
destination_table = gbq_dataset
176176

177177
test_size = 20001
178178
df = make_mixed_dataframe_v2(test_size)
@@ -205,7 +205,7 @@ def test_gbq_if_exists(
205205
self, if_exists, expected_num_rows, expectation, gbq_dataset
206206
):
207207
# GH 29598
208-
destination_table = DESTINATION_TABLE + "2"
208+
destination_table = gbq_dataset
209209

210210
test_size = 200
211211
df = make_mixed_dataframe_v2(test_size)

0 commit comments

Comments
 (0)