Skip to content

Commit fd3ebf6

Browse files
committed
Address comments from Tom
1 parent af035a6 commit fd3ebf6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

doc/source/whatsnew/v0.24.0.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ Deprecations
382382
- :meth:`DataFrame.to_stata`, :meth:`read_stata`, :class:`StataReader` and :class:`StataWriter` have deprecated the ``encoding`` argument. The encoding of a Stata dta file is determined by the file type and cannot be changed (:issue:`21244`).
383383
- :meth:`MultiIndex.to_hierarchical` is deprecated and will be removed in a future version (:issue:`21613`)
384384
- :meth:`Series.ptp` is deprecated. Use ``numpy.ptp`` instead (:issue:`21614`)
385-
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument.
385+
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument. (:issue:`21767`)
386386

387387
.. _whatsnew_0240.prior_deprecations:
388388

@@ -430,7 +430,7 @@ Bug Fixes
430430
Categorical
431431
^^^^^^^^^^^
432432

433-
- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`)
433+
- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`). In the future this will raise a ``ValueError``. Also changes the behavior of `.from_codes([1.1, 2.0])`.
434434

435435
Datetimelike
436436
^^^^^^^^^^^^

0 commit comments

Comments
 (0)