Skip to content

CI: Test pandas with numpy 1.26 #61588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
datapythonista opened this issue Jun 6, 2025 · 2 comments
Open

CI: Test pandas with numpy 1.26 #61588

datapythonista opened this issue Jun 6, 2025 · 2 comments
Assignees
@iabhi4
Labels
CI Continuous Integration Dependencies Required and optional dependencies good first issue Testing pandas testing functions or related to the test suite

Comments

@datapythonista
Copy link
Member

See #60154

We should add the build and fix the existing errors
@datapythonista datapythonista added Testing pandas testing functions or related to the test suite CI Continuous Integration Dependencies Required and optional dependencies good first issue labels Jun 6, 2025
@datapythonista datapythonista mentioned this issue Jun 6, 2025
Closed
@iabhi4
Copy link
Contributor

iabhi4 commented Jun 6, 2025

take

@iabhi4
Copy link
Contributor

iabhi4 commented Jun 7, 2025 •
edited
Loading

I did some deep testing across numpy versions and here’s what I’m seeing: The existing xfail condition for np.float32(1.1) was correct in spirit, this behavior starts changing already in numpy 1.25, not just 1.26.

If we only add np_version_gte1p26 to xfail, tests still fail under numpy 1.25.x (confirmed locally with 1.25.2).

The previous condition using NPY_PROMOTION_STATE was guarding this for <1.24 or promotion changes but now it looks like we should generalize to:

or np_version_gte1p25

That makes the test robust across current and future versions, Should I proceed with this change and send a PR?
Also regarding the CI build, I saw the earlier discussion in #60154 , would you like me to add that CI job (actions-310-numpy-126.yaml) in this PR itself, or would you prefer it as a followup PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iabhi4 iabhi4

Labels
CI Continuous Integration Dependencies Required and optional dependencies good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@datapythonista @iabhi4