PERF: column_arrays #42824
Closed
PERF: column_arrays #42824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems fine, cna you rebase |
|
can you rebase again just to be sure |
|
getting segfaults on some builds, must be coming from the json c code. @WillAyd anything stand out to you? |
|
Won’t be able to look or the next week or so. Have you tried running the tests under a debugger? Should break on any segfault
https://pandas.pydata.org/docs/development/debugging_extensions.html
FWIW I personally haven’t been getting symbols to show up in the debugger when compiling with clang - not sure what caused that recently but gdb may make things easier if available to you
…Sent from my iPhone
On Aug 5, 2021, at 9:55 PM, jbrockmendel ***@***.***> wrote:
getting segfaults on some builds, must be coming from the json c code. @WillAyd anything stand out to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
mothballing to clear the queue, need to figure out why this is segfaulting on some builds |
jbrockmendel
added
the
Mothballed
jbrockmendel
removed
the
Mothballed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaves a couple percent off of time_to_json_wide asv