Not allowing setObjectId() in ParseInstallation

Author: hermanliang

Parse/src/main/java/com/parse/ParseInstallation.java

@@ -94,6 +94,11 @@ public String getInstallationId() {
     return getString(KEY_INSTALLATION_ID);
   }
 
+  @Override
+  public void setObjectId(String newObjectId) {
+    throw new RuntimeException("Installation's objectId cannot be changed");
+  }
+
   @Override
   /* package */ boolean needsDefaultACL() {
     return false;
@@ -149,7 +154,7 @@ public Task<Void> then(Task<Void> task) throws Exception {
                 && task.getError() instanceof ParseException
                 && ((ParseException) task.getError()).getCode() == ParseException.OBJECT_NOT_FOUND) {
           synchronized (mutex) {
-            setObjectId(null);
+            setState(new State.Builder(getState()).objectId(null).build());
             markAllFieldsDirty();
             return ParseInstallation.super.saveAsync(sessionToken, toAwait);
           }

Parse/src/test/java/com/parse/ParseInstallationTest.java

@@ -319,7 +319,19 @@ public void testLocaleIdentifierSpecialCases() throws Exception {
     assertEquals("en", installation.getString(KEY_LOCALE_IDENTIFIER));
   }
 
+  @Test(expected = RuntimeException.class)
+  public void testSetObjectId() throws Exception {
+    ParseCurrentInstallationController controller =
+        mock(ParseCurrentInstallationController.class);
+    ParseInstallation currentInstallation = new ParseInstallation();
+    when(controller.getAsync()).thenReturn(Task.forResult(currentInstallation));
+    ParseCorePlugins.getInstance().registerCurrentInstallationController(controller);
 
+    ParseInstallation installation = ParseInstallation.getCurrentInstallation();
+    assertNotNull(installation);
+    verify(controller, times(1)).getAsync();
+    installation.setObjectId(null);
+  }
 
   // TODO(mengyan): Add testFetchAsync, right now we can not test super methods inside
   // testFetchAsync