LiveQuery Support for Subclasses (#662)

Author: dplewis

src/LiveQueryClient.js

@@ -389,12 +389,10 @@ class LiveQueryClient extends EventEmitter {
       break;
     default: {
       // create, update, enter, leave, delete cases
-      const className = data.object.className;
-      // Delete the extrea __type and className fields during transfer to full JSON
+
+      // Does not override / clear server data
       delete data.object.__type;
-      delete data.object.className;
-      const parseObject = new ParseObject(className);
-      parseObject._finishFetch(data.object);
+      const parseObject = ParseObject.fromJSON(data.object, false);
       if (!subscription) {
         break;
       }

src/__tests__/LiveQueryClient-test.js

@@ -416,4 +416,44 @@ describe('LiveQueryClient', () => {
     expect(liveQueryClient.socket.close).toBeCalled();
     expect(liveQueryClient.state).toBe('disconnected');
   });
+
+  it('can handle WebSocket subclass', () => {
+    const MyExtendedClass = ParseObject.extend('MyExtendedClass');
+    ParseObject.registerSubclass('MyExtendedClass', MyExtendedClass);
+
+    const liveQueryClient = new LiveQueryClient({
+      applicationId: 'applicationId',
+      serverURL: 'ws://test',
+      javascriptKey: 'javascriptKey',
+      masterKey: 'masterKey',
+      sessionToken: 'sessionToken'
+    });
+    // Add mock subscription
+    const subscription = new events.EventEmitter();
+    liveQueryClient.subscriptions.set(1, subscription);
+    const object = new MyExtendedClass();
+    object.set('key', 'value');
+    const data = {
+      op: 'create',
+      clientId: 1,
+      requestId: 1,
+      object: object._toFullJSON(),
+    };
+    const event = {
+      data: JSON.stringify(data)
+    }
+    // Register checked in advance
+    let isChecked = false;
+    subscription.on('create', function(parseObject) {
+      isChecked = true;
+      expect(parseObject instanceof MyExtendedClass).toBe(true);
+      expect(parseObject.get('key')).toEqual('value');
+      expect(parseObject.get('className')).toBeUndefined();
+      expect(parseObject.get('__type')).toBeUndefined();
+    });
+
+    liveQueryClient._handleWebSocketMessage(event);
+
+    expect(isChecked).toBe(true);
+  });
 });