Skip to content

Commit c3fa1e8

Browse files
committed
swith to POST if authData detected
1 parent 67bc770 commit c3fa1e8

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

src/ParseUser.js

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,21 +1133,24 @@ const DefaultController = {
11331133
password: user.get('password'),
11341134
authData: user.get('authData'),
11351135
};
1136-
return RESTController.request(options.usePost ? 'POST' : 'GET', 'login', auth, options).then(
1137-
response => {
1138-
user._migrateId(response.objectId);
1139-
user._setExisted(true);
1140-
stateController.setPendingOp(user._getStateIdentifier(), 'username', undefined);
1141-
stateController.setPendingOp(user._getStateIdentifier(), 'password', undefined);
1142-
response.password = undefined;
1143-
user._finishFetch(response);
1144-
if (!canUseCurrentUser) {
1145-
// We can't set the current user, so just return the one we logged in
1146-
return Promise.resolve(user);
1147-
}
1148-
return DefaultController.setCurrentUser(user);
1136+
return RESTController.request(
1137+
options.usePost || auth.authData ? 'POST' : 'GET',
1138+
'login',
1139+
auth,
1140+
options
1141+
).then(response => {
1142+
user._migrateId(response.objectId);
1143+
user._setExisted(true);
1144+
stateController.setPendingOp(user._getStateIdentifier(), 'username', undefined);
1145+
stateController.setPendingOp(user._getStateIdentifier(), 'password', undefined);
1146+
response.password = undefined;
1147+
user._finishFetch(response);
1148+
if (!canUseCurrentUser) {
1149+
// We can't set the current user, so just return the one we logged in
1150+
return Promise.resolve(user);
11491151
}
1150-
);
1152+
return DefaultController.setCurrentUser(user);
1153+
});
11511154
},
11521155

11531156
become(user: ParseUser, options: RequestOptions): Promise<ParseUser> {

src/__tests__/ParseUser-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ describe('ParseUser', () => {
385385
ParseUser._clearCache();
386386
CoreManager.setRESTController({
387387
request(method, path, body) {
388-
expect(method).toBe('GET');
388+
expect(method).toBe('POST');
389389
expect(path).toBe('login');
390390
expect(body.username).toBe('username');
391391
expect(body.password).toBe('password');

0 commit comments

Comments
 (0)