Improve integration testing (#1292)

* Improve integration testing

* clean up

* remove beforeAll to prevent concurrency

* Add `use strict` when possible

* Refactor tests with afterEach

* try jasmine randomize tests

* turn of random

Author: dplewis

integration/server.js

@@ -2,7 +2,17 @@
   "env": {
       "jasmine": true
   },
-  "globals": {},
+  "globals": {
+    "Child": true,
+    "Container": true,
+    "DiffObject": true,
+    "Item": true,
+    "Parse": true,
+    "Parent": true,
+    "reconfigureServer": true,
+    "TestObject": true,
+    "TestPoint": true
+  },
   "rules": {
     "no-console": [0],
     "no-var": "error"

integration/test/.eslintrc.json

@@ -1,17 +1,9 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
 describe('Array Operations', () => {
-  beforeAll(done => {
-    Parse.initialize('integration');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear().then(done).catch(done.fail);
-  });
-
   it('initializes a field', done => {
     const object = new Parse.Object('TestObject');
     object.set('strings', ['foo', 'bar', 'baz']);
@@ -375,7 +367,7 @@ describe('Array Operations', () => {
       });
   });
 
-  it('fails when combining remove with add unique', done => {
+  it('fails when combining addUnique with remove', done => {
     const object = new Parse.Object('TestObject');
     object.set('strings', ['foo', 'bar']);
     object

integration/test/ArrayOperationsTest.js

@@ -1,25 +1,9 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
-const TestObject = Parse.Object.extend('TestObject');
-const Parent = Parse.Object.extend('Parent');
-const Child = Parse.Object.extend('Child');
-
 describe('Dirty Objects', () => {
-  beforeEach(done => {
-    Parse.initialize('integration');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear()
-      .then(() => {
-        done();
-      })
-      .catch(done.fail);
-  });
-
   it('tracks dirty arrays', done => {
     const array = [1];
     const object = new TestObject();

integration/test/DirtyTest.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const clear = require('./clear');
 const Parse = require('../../node');
 
 const Item = Parse.Object.extend('IdempotencyItem');
@@ -21,14 +20,8 @@ function DuplicateXHR(requestId) {
 }
 
 describe('Idempotency', () => {
-  beforeEach(done => {
-    Parse.initialize('integration', null, 'notsosecret');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
+  beforeEach(() => {
     RESTController._setXHR(XHR);
-    clear().then(() => {
-      done();
-    });
   });
 
   it('handle duplicate cloud code function request', async () => {

integration/test/IdempotencyTest.js

@@ -1,23 +1,9 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
-const TestObject = Parse.Object.extend('TestObject');
-
 describe('Increment', () => {
-  beforeEach(done => {
-    Parse.initialize('integration');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear()
-      .then(() => {
-        done();
-      })
-      .catch(done.fail);
-  });
-
   it('can increment a field', done => {
     const object = new TestObject();
     object.set('score', 1);

integration/test/IncrementTest.js

@@ -1,29 +1,11 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
-const TestObject = Parse.Object.extend('TestObject');
-
 describe('Parse.ACL', () => {
-  beforeEach(done => {
-    Parse.initialize('integration');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
+  beforeEach(() => {
     Parse.User.enableUnsafeCurrentUser();
-    clear()
-      .then(() => {
-        Parse.User.logOut().then(
-          () => {
-            done();
-          },
-          () => {
-            done();
-          }
-        );
-      })
-      .catch(done.fail);
   });
 
   it('acl must be valid', () => {
@@ -61,7 +43,7 @@ describe('Parse.ACL', () => {
     assert.equal(object.getACL().getPublicReadAccess(), false);
     assert.equal(object.getACL().getPublicWriteAccess(), false);
 
-    await await Parse.User.logOut();
+    await Parse.User.logOut();
     try {
       const query = new Parse.Query(TestObject);
       await query.get(object.id);
@@ -214,7 +196,7 @@ describe('Parse.ACL', () => {
     object.getACL().setPublicReadAccess(true);
     await object.save();
 
-    Parse.User.logOut();
+    await Parse.User.logOut();
     const o = await new Parse.Query(TestObject).get(object.id);
     assert(o);
   });
@@ -232,7 +214,7 @@ describe('Parse.ACL', () => {
     object.getACL().setPublicReadAccess(true);
     await object.save();
 
-    Parse.User.logOut();
+    await Parse.User.logOut();
     const o = await new Parse.Query('AlsoUniqueObject').find();
 
     assert(o.length > 0);
@@ -251,7 +233,7 @@ describe('Parse.ACL', () => {
     object.getACL().setPublicReadAccess(true);
     await object.save();
 
-    Parse.User.logOut();
+    await Parse.User.logOut();
     object.set('score', 10);
     try {
       await object.save();
@@ -273,7 +255,7 @@ describe('Parse.ACL', () => {
     object.getACL().setPublicReadAccess(true);
     await object.save();
 
-    Parse.User.logOut();
+    await Parse.User.logOut();
     try {
       await object.destroy();
     } catch (e) {

integration/test/ParseACLTest.js

@@ -1,25 +1,10 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 const sleep = require('./sleep');
 
 describe('Parse Cloud', () => {
-  beforeAll(done => {
-    Parse.initialize('integration', null, 'notsosecret');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear().then(
-      () => {
-        done();
-      },
-      () => {
-        done();
-      }
-    );
-  });
-
   it('run function', done => {
     const params = { key1: 'value2', key2: 'value1' };
     Parse.Cloud.run('bar', params)

integration/test/ParseCloudTest.js

@@ -1,23 +1,13 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
 function testConfig() {
   return Parse.Config.save({ internal: 'i', string: 's', number: 12 }, { internal: true });
 }
 
 describe('Parse Config', () => {
-  beforeEach(done => {
-    Parse.initialize('integration', null, 'notsosecret');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear().then(() => {
-      done();
-    });
-  });
-
   it('can create a config', async () => {
     const config = await testConfig();
 

integration/test/ParseConfigTest.js

@@ -1,17 +1,9 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
 describe('Parse.File', () => {
-  beforeEach(done => {
-    Parse.initialize('integration', null, 'notsosecret');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-    clear().then(done).catch(done.fail);
-  });
-
   it('can save file with uri', async () => {
     // Try https
     const parseLogo =

integration/test/ParseFileTest.js

@@ -1,23 +1,12 @@
 'use strict';
 
 const assert = require('assert');
-const clear = require('./clear');
 const Parse = require('../../node');
 
 const southwestOfSF = new Parse.GeoPoint(37.708813, -122.526398);
 const northeastOfSF = new Parse.GeoPoint(37.822802, -122.373962);
 
 describe('Geo Box', () => {
-  beforeAll(() => {
-    Parse.initialize('integration');
-    Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
-    Parse.Storage._clear();
-  });
-
-  beforeEach(done => {
-    clear().then(done).catch(done);
-  });
-
   it('can query geo boxes', done => {
     const caltrainStationLocation = new Parse.GeoPoint(37.776346, -122.394218);
     const caltrainStation = new Parse.Object('Location');