Skip to content

fix: UUID deep require is deprecated and may cause issues #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: UUID deep require is deprecated and may cause issues #1582

wants to merge 1 commit into from

Conversation

jpgupta
Copy link

@jpgupta jpgupta commented Oct 24, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Re-creating changes from #1492, on a new branch (running into various lockfile issues)

Closes #1491

Approach

TODOs before merging

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 24, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@jpgupta jpgupta changed the title Upgrade uuid refactor: bump UUID dep, remove 'deep require' of uuid (v2) Oct 24, 2022
@dplewis dplewis mentioned this pull request Jan 7, 2023
Closed
4 tasks
@mtrezza
Copy link
Member

mtrezza commented Jan 7, 2023

@jpgupta could you rebase this on the alpha branch, so we can merge this?

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: bump UUID dep, remove 'deep require' of uuid (v2) refactor: Bump UUID dep, remove 'deep require' of uuid (v2) Jan 7, 2023
@mtrezza mtrezza changed the title refactor: Bump UUID dep, remove 'deep require' of uuid (v2) fix: UUID deep require is deprecated and may cause issues Jan 7, 2023
@dplewis
Copy link
Member

dplewis commented Jan 27, 2023

Closing for bot to recreate PR.

@dplewis dplewis closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUID/v4 require() uses a deprecated approach, can cause issues with other packages
3 participants
@jpgupta @mtrezza @dplewis