Add sensible string representation of ParseError objects #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our error logs are filled with thousands of "[Object object]" due to the ParseError object not having a sensible string representation. Errors ripple down to the Express.js error log handler, which calls
console.error(err.stack || err.toString())
. In our case, these are typically209 Invalid session token
errors, as we just migrated to using revocable sessions. The proposed fix in this pull request is to add atoSting()
method for ParseErrors.