Checks for nil applicationId and clientKey #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! I'll let @nlutsenko take a peek and get his thoughts before merging. |
|
Hey @gonzalonunez, thanks for implementing this! |
|
Ok sounds good, I'm on it! |
|
@gonzalonunez, last request - can you squash everything into a single commit? I will merge it straight after that is done. Thanks for the help with this one! |
gonzalonunez
force-pushed
the
initializationChecks
branch
from
920b36c to
4b37e95
Compare
|
Squashed 👍 |
|
Perfect! Merging it in! |
nlutsenko
added a commit
that referenced
this pull request
Aug 28, 2015
Checks for nil applicationId and clientKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searched over the TODOs and found this. The reason I passed the nil string 'yolo' in the tests is because if you actually pass in nil you'll get a warning.
I don't have too much professional experience with unit tests, please let me know if there's anything wrong with these tests.