Don't use transactions by default for internal SDK calls

Author: cbaker6

CHANGELOG.md

@@ -1,12 +1,18 @@
 # Parse-Swift Changelog
 
 ### main
-[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.0...main)
+[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.1...main)
 * _Contributing to this repo? Add info about your change here to be included in the next release_
 
+### 1.8.0
+[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.0...1.8.1)
+
 __Improvements__
 - Append instead of replace when using query select, exclude, include, and fields ([#155](https://github.com/parse-community/Parse-Swift/pull/155)), thanks to [Corey Baker](https://github.com/cbaker6).
 
+__Fixes__
+- Transactions currently don't work when using mongoDB(postgres does work) on the parse-server. Internal use of transactions are disabled by default. If you want the Swift SDK to use transactions internally, you need to set useTransactionsInternally=true when configuring the client. It is recommended not to use transactions if you are using mongoDB until it's fixed on the server ([#158](https://github.com/parse-community/Parse-Swift/pull/158)), thanks to [Corey Baker](https://github.com/cbaker6).
+
 ### 1.8.0
 [Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.7.2...1.8.0)
 

ParseSwift.playground/Pages/1 - Your first Object.xcplaygroundpage/Contents.swift

@@ -114,7 +114,8 @@ var score2ForFetchedLater: GameScore?
 }
 
 //: Saving multiple GameScores at once using a transaction.
-[score, score2].saveAll(transaction: true) { results in
+//: Currently doesn't work on mongo
+/*[score, score2].saveAll(transaction: true) { results in
     switch results {
     case .success(let otherResults):
         var index = 0
@@ -134,7 +135,7 @@ var score2ForFetchedLater: GameScore?
     case .failure(let error):
         assertionFailure("Error saving: \(error)")
     }
-}
+}*/
 
 //: Save synchronously (not preferred - all operations on main queue).
 let savedScore: GameScore?
@@ -270,7 +271,7 @@ do {
 }
 
 //: Asynchronously (preferred way) deleteAll GameScores based on it's objectId alone.
-[scoreToFetch, score2ToFetch].deleteAll(transaction: true) { result in
+[scoreToFetch, score2ToFetch].deleteAll { result in
     switch result {
     case .success(let deletedScores):
         deletedScores.forEach { result in

ParseSwift.playground/Sources/Common.swift

@@ -5,7 +5,8 @@ public func initializeParse() {
     ParseSwift.initialize(applicationId: "applicationId",
                      clientKey: "clientKey",
                      masterKey: "masterKey",
-                     serverURL: URL(string: "http://localhost:1337/1")!)
+                     serverURL: URL(string: "http://localhost:1337/1")!,
+                     useTransactionsInternally: false)
 }
 
 public func initializeParseCustomObjectId() {

Sources/ParseSwift/Objects/ParseObject.swift

@@ -725,7 +725,7 @@ extension ParseObject {
 // MARK: Savable Encodable Version
 internal extension ParseType {
     func saveAll(objects: [ParseType],
-                 transaction: Bool = true,
+                 transaction: Bool = ParseSwift.configuration.useTransactionsInternally,
                  options: API.Options = []) throws -> [(Result<PointerType, ParseError>)] {
         try API.NonParseBodyCommand<AnyCodable, PointerType>
                 .batch(objects: objects,

Sources/ParseSwift/Parse.swift

@@ -26,6 +26,10 @@ public struct ParseConfiguration {
     /// Allows objectIds to be created on the client.
     var allowCustomObjectId = false
 
+    /// Use transactions inside the Client SDK.
+    /// - warning: This is experimental and known not to work with mongoDB.
+    var useTransactionsInternally = false
+
     internal var authentication: ((URLAuthenticationChallenge,
                                    (URLSession.AuthChallengeDisposition,
                                     URLCredential?) -> Void) -> Void)?
@@ -57,6 +61,7 @@ public struct ParseConfiguration {
                 serverURL: URL,
                 liveQueryServerURL: URL? = nil,
                 allowCustomObjectId: Bool = false,
+                useTransactionsInternally: Bool = false,
                 keyValueStore: ParseKeyValueStore? = nil,
                 authentication: ((URLAuthenticationChallenge,
                                   (URLSession.AuthChallengeDisposition,
@@ -67,6 +72,7 @@ public struct ParseConfiguration {
         self.serverURL = serverURL
         self.liveQuerysServerURL = liveQueryServerURL
         self.allowCustomObjectId = allowCustomObjectId
+        self.useTransactionsInternally = useTransactionsInternally
         self.mountPath = "/" + serverURL.pathComponents
             .filter { $0 != "/" }
             .joined(separator: "/")
@@ -153,6 +159,7 @@ public struct ParseSwift {
         serverURL: URL,
         liveQueryServerURL: URL? = nil,
         allowCustomObjectId: Bool = false,
+        useTransactionsInternally: Bool = false,
         keyValueStore: ParseKeyValueStore? = nil,
         migrateFromObjcSDK: Bool = false,
         authentication: ((URLAuthenticationChallenge,
@@ -165,6 +172,7 @@ public struct ParseSwift {
                                         serverURL: serverURL,
                                         liveQueryServerURL: liveQueryServerURL,
                                         allowCustomObjectId: allowCustomObjectId,
+                                        useTransactionsInternally: useTransactionsInternally,
                                         keyValueStore: keyValueStore,
                                         authentication: authentication),
                    migrateFromObjcSDK: migrateFromObjcSDK)
@@ -176,6 +184,7 @@ public struct ParseSwift {
                                     serverURL: URL,
                                     liveQueryServerURL: URL? = nil,
                                     allowCustomObjectId: Bool = false,
+                                    useTransactionsInternally: Bool = false,
                                     keyValueStore: ParseKeyValueStore? = nil,
                                     migrateFromObjcSDK: Bool = false,
                                     testing: Bool = false,
@@ -188,6 +197,7 @@ public struct ParseSwift {
                                         serverURL: serverURL,
                                         liveQueryServerURL: liveQueryServerURL,
                                         allowCustomObjectId: allowCustomObjectId,
+                                        useTransactionsInternally: useTransactionsInternally,
                                         keyValueStore: keyValueStore,
                                         authentication: authentication),
                    migrateFromObjcSDK: migrateFromObjcSDK)