Skip to content

Commit 4ffc808

Browse files
committed
Fix broken testcases
1 parent 1ca97e1 commit 4ffc808

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -211,11 +211,6 @@ public final class ParseLiveQuery: NSObject {
211211
close(useDedicatedQueue: false)
212212
authenticationDelegate = nil
213213
receiveDelegate = nil
214-
if task != nil {
215-
URLSession.liveQuery.delegates.removeValue(forKey: task)
216-
} else {
217-
task = nil
218-
}
219214
}
220215
}
221216

@@ -518,8 +513,8 @@ extension ParseLiveQuery {
518513
if error == nil {
519514
self.isConnecting = true
520515
}
516+
completion(error)
521517
}
522-
completion(nil)
523518
} catch {
524519
completion(error)
525520
}

Tests/ParseSwiftTests/ParseLiveQueryTests.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,14 +316,15 @@ class ParseLiveQueryTests: XCTestCase {
316316
}
317317
client.isSocketEstablished = true // Socket neets to be true
318318
client.isConnecting = true
319-
client.attempts = 50
320319
client.isConnected = true
320+
client.attempts = 5
321321
client.clientId = "yolo"
322+
client.isDisconnectedByUser = false
322323

323324
XCTAssertEqual(client.isSocketEstablished, true)
324325
XCTAssertEqual(client.isConnecting, false)
325326
XCTAssertEqual(client.clientId, "yolo")
326-
XCTAssertEqual(client.attempts, 1)
327+
XCTAssertEqual(client.attempts, 5)
327328
}
328329

329330
func testDisconnectedState() throws {
@@ -384,7 +385,7 @@ class ParseLiveQueryTests: XCTestCase {
384385
XCTAssertEqual(client.clientId, "yolo")
385386
client.close()
386387

387-
XCTAssertEqual(client.isSocketEstablished, true)
388+
XCTAssertEqual(client.isSocketEstablished, false)
388389
XCTAssertEqual(client.isConnected, false)
389390
XCTAssertEqual(client.isConnecting, false)
390391
XCTAssertNil(client.clientId)

0 commit comments

Comments
 (0)