Skip to content

Commit 73fa31e

Browse files
committed
Add changelog entry
1 parent 63e309b commit 73fa31e

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.3...main)
55
* _Contributing to this repo? Add info about your change here to be included in the next release_
66

7+
__Fixes__
8+
- Fixed a bug in LiveQuery that prevented reconnecting after a connection was closed. Also added a sendPing method to LiveQuery ([#172](https://github.com/parse-community/Parse-Swift/pull/172)), thanks to [Corey Baker](https://github.com/cbaker6).
9+
710
### 1.8.3
811
[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.2...1.8.3)
912

ParseSwift.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -897,8 +897,8 @@
897897
70110D5B2506ED0E0091CC1D /* ParseInstallationTests.swift */,
898898
70386A5B25D9A4010048EC1B /* ParseLDAPCombineTests.swift */,
899899
70386A4525D99C8B0048EC1B /* ParseLDAPTests.swift */,
900-
7003963A25A288100052CB31 /* ParseLiveQueryTests.swift */,
901900
918CED5D268618C600CFDC83 /* ParseLiveQueryCombineTests.swift */,
901+
7003963A25A288100052CB31 /* ParseLiveQueryTests.swift */,
902902
70C7DC2024D20F190050419B /* ParseObjectBatchTests.swift */,
903903
7044C1DE25C5C70D0011F6E7 /* ParseObjectCombine.swift */,
904904
70732C592606CCAD000CAB81 /* ParseObjectCustomObjectIdTests.swift */,
@@ -1054,11 +1054,11 @@
10541054
isa = PBXGroup;
10551055
children = (
10561056
70510AAB259EE25E00FEA700 /* LiveQuerySocket.swift */,
1057-
70C5655825AA147B00BDD57F /* ParseLiveQueryConstants.swift */,
10581057
7003959425A10DFC0052CB31 /* Messages.swift */,
10591058
700395A225A119430052CB31 /* Operations.swift */,
10601059
7003960825A184EF0052CB31 /* ParseLiveQuery.swift */,
10611060
918CED582684C74000CFDC83 /* ParseLiveQuery+combine.swift */,
1061+
70C5655825AA147B00BDD57F /* ParseLiveQueryConstants.swift */,
10621062
700395B925A1470F0052CB31 /* Subscription.swift */,
10631063
705D950725BE4C08003EF6F8 /* SubscriptionCallback.swift */,
10641064
700395DE25A147C40052CB31 /* Protocols */,

Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,7 @@ extension ParseLiveQuery {
588588
self.task.cancel()
589589
}
590590
URLSession.liveQuery.delegates.removeValue(forKey: self.task)
591+
self.task = nil
591592
}
592593
} else {
593594
if self.isConnected {
@@ -596,6 +597,7 @@ extension ParseLiveQuery {
596597
if self.task != nil {
597598
URLSession.liveQuery.delegates.removeValue(forKey: self.task)
598599
}
600+
self.task = nil
599601
}
600602
}
601603

Tests/ParseSwiftTests/ParseLiveQueryTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -751,9 +751,8 @@ class ParseLiveQueryTests: XCTestCase {
751751
XCTFail("Should be able to get client")
752752
return
753753
}
754-
try pretendToBeConnected()
755754

756-
guard let url = URL(string: "http://parse.com") else {
755+
guard let url = URL(string: "wss://parse.com") else {
757756
XCTFail("should create url")
758757
return
759758
}

0 commit comments

Comments
 (0)