Skip to content

Commit b01c501

Browse files
committed
set verifyPassword usingPost default to false
1 parent 787c2b1 commit b01c501

File tree

6 files changed

+19
-15
lines changed

6 files changed

+19
-15
lines changed

.swiftlint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ excluded: # paths to ignore during linting. Takes precedence over `included`.
99
- Tests/ParseSwiftTests/ParseEncoderTests
1010
- DerivedData
1111
- .build
12+
- .dependencies

ParseSwift.podtemplate

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ Pod::Spec.new do |s|
1414
s.osx.deployment_target = "10.15"
1515
s.tvos.deployment_target = "13.0"
1616
s.watchos.deployment_target = "6.0"
17-
s.swift_versions = ['5.1', '5.2', '5.3', '5.4', '5.5']
17+
s.swift_versions = ['5.3', '5.4', '5.5', '5.6']
1818
s.source_files = "Sources/ParseSwift/**/*.swift"
1919
s.license = {
2020
:type => "MIT",
2121
:text => <<-LICENSE
22-
Copyright (c) 2021 parse-community
22+
Copyright (c) 2022 parse-community
2323
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
2424
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
2525
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Sources/ParseSwift/Documentation.docc/Your First Object.tutorial

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@Tutorial(time: 15) {
1+
@Tutorial(time: 1) {
22
@Intro(title: "Your First Object") {
33

44
}

Sources/ParseSwift/Objects/ParseUser+async.swift

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,16 +143,17 @@ public extension ParseUser {
143143

144144
- parameter password: The password to be verified.
145145
- parameter usingPost: Set to **true** to use **POST** for sending. Will use **GET**
146-
otherwise. Defaults to **true**.
146+
otherwise. Defaults to **false**.
147147
- parameter options: A set of header options sent to the server. Defaults to an empty set.
148148
- throws: An error of type `ParseError`.
149149
- note: The default cache policy for this method is `.reloadIgnoringLocalCacheData`. If a developer
150150
desires a different policy, it should be inserted in `options`.
151-
- warning: `usingPost == true` requires Parse Server > 5.0.0. Othewise you should set
152-
`usingPost = false`.
151+
- warning: `usingPost == true` requires the
152+
[issue](https://github.com/parse-community/parse-server/issues/7784) to be addressed on
153+
the Parse Server, othewise you should set `usingPost = false`.
153154
*/
154155
static func verifyPassword(password: String,
155-
usingPost: Bool = true,
156+
usingPost: Bool = false,
156157
options: API.Options = []) async throws -> Self {
157158
try await withCheckedThrowingContinuation { continuation in
158159
Self.verifyPassword(password: password,

Sources/ParseSwift/Objects/ParseUser+combine.swift

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,16 +134,17 @@ public extension ParseUser {
134134
Publishes when complete.
135135
- parameter password: The password to be verified.
136136
- parameter usingPost: Set to **true** to use **POST** for sending. Will use **GET**
137-
otherwise. Defaults to **true**.
137+
otherwise. Defaults to **false**.
138138
- parameter options: A set of header options sent to the server. Defaults to an empty set.
139139
- returns: A publisher that eventually produces a single value and then finishes or fails.
140-
- warning: `usingPost == true` requires Parse Server > 5.0.0. Othewise you should set
141-
`usingPost = false`.
142140
- note: The default cache policy for this method is `.reloadIgnoringLocalCacheData`. If a developer
143141
desires a different policy, it should be inserted in `options`.
142+
- warning: `usingPost == true` requires the
143+
[issue](https://github.com/parse-community/parse-server/issues/7784) to be addressed on
144+
the Parse Server, othewise you should set `usingPost = false`.
144145
*/
145146
static func verifyPasswordPublisher(password: String,
146-
usingPost: Bool = true,
147+
usingPost: Bool = false,
147148
options: API.Options = []) -> Future<Self, ParseError> {
148149
Future { promise in
149150
Self.verifyPassword(password: password,

Sources/ParseSwift/Objects/ParseUser.swift

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -478,17 +478,18 @@ extension ParseUser {
478478
Verifies *asynchronously* whether the specified password associated with the user account is valid.
479479
- parameter password: The password to be verified.
480480
- parameter usingPost: Set to **true** to use **POST** for sending. Will use **GET**
481-
otherwise. Defaults to **true**.
481+
otherwise. Defaults to **false**.
482482
- parameter options: A set of header options sent to the server. Defaults to an empty set.
483483
- parameter callbackQueue: The queue to return to after completion. Default value of .main.
484484
- parameter completion: A block that will be called when the verification request completes or fails.
485485
- note: The default cache policy for this method is `.reloadIgnoringLocalCacheData`. If a developer
486486
desires a different policy, it should be inserted in `options`.
487-
- warning: `usingPost == true` requires Parse Server > 5.0.0. Othewise you should set
488-
`usingPost = false`.
487+
- warning: `usingPost == true` requires the
488+
[issue](https://github.com/parse-community/parse-server/issues/7784) to be addressed on
489+
the Parse Server, othewise you should set `usingPost = false`.
489490
*/
490491
public static func verifyPassword(password: String,
491-
usingPost: Bool = true,
492+
usingPost: Bool = false,
492493
options: API.Options = [],
493494
callbackQueue: DispatchQueue = .main,
494495
completion: @escaping (Result<Self, ParseError>) -> Void) {

0 commit comments

Comments
 (0)