Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Update all dependencies and fix usage of deprecated APIs. #53

Merged
merged 6 commits into from
Jul 29, 2016

Conversation

nlutsenko
Copy link
Contributor

@nlutsenko nlutsenko commented Jul 29, 2016

Closes #50
Closes #51
Closes #52

Many thanks to @p4checo, @jorourke for the contributions, all credit for these changes goes to them.

@nlutsenko nlutsenko merged commit 19845eb into master Jul 29, 2016
@nlutsenko nlutsenko deleted the nlutsenko.dependencies branch July 29, 2016 21:24
@p4checo
Copy link

p4checo commented Jul 29, 2016

Hi @nlutsenko,

Was there something wrong with my PR?

I'm asking because you replicate most things in it (even though you added more changes too).

I don't know if this is normal procedure, but personally I find this to be a little awkward and not very welcoming to outside contributors. Are changes to this repo supposed to come only from FB employees?

Cheers

@nlutsenko
Copy link
Contributor Author

Sorry, no not really, your changes are great (hence the comment in the PR).
I've seen tests failing (and we don't merge anything that's failing), and wanted to make sure that we get everything going and at that point it was easier to send a PR that was fixing everything 😁

Please keep the PRs coming, I would love to help you take the LiveQuery client forward.

@p4checo
Copy link

p4checo commented Jul 29, 2016

I understand that the tests should pass, but I honestly don't think this is the most "constructive" approach in an open source project. It is surely faster, though.

I would expect maintainers to work together with contributors, and not simply take the changes and do a PR themselves. But that's just my opinion.

Anyway, thanks for editing the PR description and giving credit 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants