set flag cached & making request if not cached

Author: sadakchap

src/components/ColumnsConfiguration/ColumnsConfiguration.react.js

@@ -93,6 +93,9 @@ export default class ColumnsConfiguration extends React.Component {
                         if (this.props.className === '_User' && name === 'password') {
                           shouldReload = false;
                         }
+                        if (updatedOrder[index].cached) {
+                          shouldReload = false;
+                        }
                         handleColumnsOrder(updatedOrder, shouldReload);
                       }}
                       handleColumnDragDrop={handleColumnDragDrop} />

src/dashboard/Data/Browser/Browser.react.js

@@ -681,6 +681,7 @@ class Browser extends DashboardView {
       for (let columnsKey in columns) {
         query.exclude(columns[columnsKey]);
       }
+      ColumnPreferences.updateCachedColumns(this.context.currentApp.applicationId, className);
     }
   }
 

src/lib/ColumnPreferences.js

@@ -73,7 +73,7 @@ export function getColumnSort(sortBy, appId, className) {
 
 export function getOrder(cols, appId, className, defaultPrefs) {
 
-  let prefs = getPreferences(appId, className) || [ { name: 'objectId', width: DEFAULT_WIDTH, visible: true } ];
+  let prefs = getPreferences(appId, className) || [ { name: 'objectId', width: DEFAULT_WIDTH, visible: true, cached: true } ];
   if (defaultPrefs) {
     prefs = defaultPrefs;
   }
@@ -87,7 +87,7 @@ export function getOrder(cols, appId, className, defaultPrefs) {
   for (let name in cols) {
     requested[name] = true;
     if (!seen[name]) {
-      order.push({ name: name, width: DEFAULT_WIDTH, visible: !defaultPrefs, required: cols[name]['required'] });
+      order.push({ name: name, width: DEFAULT_WIDTH, visible: !defaultPrefs, required: cols[name]['required'], cached: !defaultPrefs });
       seen[name] = true;
       updated = true;
     }
@@ -100,6 +100,7 @@ export function getOrder(cols, appId, className, defaultPrefs) {
     // and updates the cached preferences.
     if (typeof visible === 'undefined') {
       order[i].visible = true;
+      order[i].cached = visible;
       updated = true;
     }
     // If "required" attribute is not defined, set it to false
@@ -118,6 +119,18 @@ export function getOrder(cols, appId, className, defaultPrefs) {
   return filtered;
 }
 
+export function updateCachedColumns(appId, className) {
+  let prefs = getPreferences(appId, className);
+  let order = [].concat(prefs);
+
+  for (let col of order) {
+    let { visible } = col;
+    col.cached = visible;
+  }
+  updatePreferences(order, appId, className);
+  return order;
+}
+
 function path(appId, className) {
   return `ParseDashboard:${VERSION}:${appId}:${className}`;
 }