Skip to content

Commit e63c958

Browse files
committed
remove incorrect loading calls
1 parent cf0bd2d commit e63c958

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/dashboard/Data/Browser/Browser.react.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,6 @@ class Browser extends DashboardView {
898898

899899
async fetchParseData(source, filters) {
900900
const { useMasterKey, skip, limit } = this.state;
901-
this.setLoading(true);
902901
this.setState({
903902
data: null,
904903
})
@@ -931,8 +930,6 @@ class Browser extends DashboardView {
931930
this.setState({ isUnique, uniqueField });
932931

933932
const data = await promise;
934-
935-
this.setLoading(false);
936933
return data;
937934
}
938935

@@ -2098,7 +2095,6 @@ class Browser extends DashboardView {
20982095
classes={this.classes}
20992096
classwiseCloudFunctions={this.state.classwiseCloudFunctions}
21002097
callCloudFunction={this.fetchAggregationPanelData}
2101-
isLoading={this.state.isLoading}
21022098
isLoadingCloudFunction={this.state.isLoadingInfoPanel}
21032099
setLoadingInfoPanel={this.setLoadingInfoPanel}
21042100
AggregationPanelData={this.state.AggregationPanelData}

src/dashboard/Data/Browser/BrowserTable.react.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@
66
* the root directory of this source tree.
77
*/
88
import BrowserRow from 'components/BrowserRow/BrowserRow.react';
9+
import Button from 'components/Button/Button.react';
910
import DataBrowserHeaderBar from 'components/DataBrowserHeaderBar/DataBrowserHeaderBar.react';
10-
import Editor from 'dashboard/Data/Browser/Editor.react';
1111
import EmptyState from 'components/EmptyState/EmptyState.react';
1212
import Icon from 'components/Icon/Icon.react';
13+
import { CurrentApp } from 'context/currentApp';
14+
import styles from 'dashboard/Data/Browser/Browser.scss';
15+
import Editor from 'dashboard/Data/Browser/Editor.react';
1316
import Parse from 'parse';
1417
import encode from 'parse/lib/browser/encode';
1518
import React from 'react';
16-
import styles from 'dashboard/Data/Browser/Browser.scss';
17-
import Button from 'components/Button/Button.react';
18-
import { CurrentApp } from 'context/currentApp';
1919

2020
const ROW_HEIGHT = 30;
2121

@@ -560,7 +560,7 @@ export default class BrowserTable extends React.Component {
560560
onResize={this.props.handleResize}
561561
onAddColumn={this.props.onAddColumn}
562562
preventSchemaEdits={this.context.preventSchemaEdits}
563-
isDataLoaded={!this.props.isLoading}
563+
isDataLoaded={!!this.props.data}
564564
setSelectedObjectId={this.props.setSelectedObjectId}
565565
setCurrent={this.props.setCurrent}
566566
/>

0 commit comments

Comments
 (0)