Skip to content

Commit ea0a664

Browse files
refactor: replace query-string with URLSearchParams (#1819)
* refactor: replace query-string with URLSearchParams * chore: revert eslint changes
1 parent 0b2f51a commit ea0a664

File tree

4 files changed

+8
-38
lines changed

4 files changed

+8
-38
lines changed

package-lock.json

Lines changed: 2 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"prismjs": "1.25.0",
6262
"prop-types": "15.7.2",
6363
"qrcode": "1.4.4",
64-
"query-string": "6.14.1",
6564
"react": "16.14.0",
6665
"react-ace": "9.4.3",
6766
"react-dnd": "10.0.2",

src/dashboard/Data/Browser/Browser.react.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import stringCompare from 'lib/stringCompare';
3434
import styles from 'dashboard/Data/Browser/Browser.scss';
3535
import subscribeTo from 'lib/subscribeTo';
3636
import * as ColumnPreferences from 'lib/ColumnPreferences';
37-
import * as queryString from 'query-string';
3837
import { Helmet } from 'react-helmet';
3938
import PropTypes from 'lib/PropTypes';
4039
import ParseApp from 'lib/ParseApp';
@@ -213,9 +212,9 @@ class Browser extends DashboardView {
213212
if (!props || !props.location || !props.location.search) {
214213
return filters;
215214
}
216-
const query = queryString.parse(props.location.search);
217-
if (query.filters) {
218-
const queryFilters = JSON.parse(query.filters);
215+
const query = new URLSearchParams(props.location.search);
216+
if (query.has('filters')) {
217+
const queryFilters = JSON.parse(query.get('filters'));
219218
queryFilters.forEach((filter) => filters = filters.push(new Map(filter)));
220219
}
221220
return filters;

src/dashboard/Push/PushNew.react.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import Toggle from 'components/Toggle/Toggle.react';
3636
import Toolbar from 'components/Toolbar/Toolbar.react';
3737
import { Directions } from 'lib/Constants';
3838
import { extractExpiration, extractPushTime } from 'lib/extractTime';
39-
import * as queryString from 'query-string';
4039

4140
const PARSE_SERVER_SUPPORTS_AB_TESTING = false;
4241

@@ -148,11 +147,11 @@ class PushNew extends DashboardView {
148147
componentWillMount() {
149148
this.props.schema.dispatch(SchemaStore.ActionTypes.FETCH);
150149
let options = { xhrKey: XHR_KEY };
151-
const query = queryString.parse(this.props.location.search);
152-
if (query.audienceId) {
150+
const query = new URLSearchParams(this.props.location.search);
151+
if (query.has('audienceId')) {
153152
options.limit = PushConstants.SHOW_MORE_LIMIT;
154153
options.min = PushConstants.INITIAL_PAGE_SIZE;
155-
this.setState({ initialAudienceId: query.audienceId });
154+
this.setState({ initialAudienceId: query.get('audienceId') });
156155
}
157156
this.props.pushaudiences.dispatch(PushAudiencesStore.ActionTypes.FETCH,
158157
options).then(() => {

0 commit comments

Comments
 (0)