Skip to content

Commit 0e92f76

Browse files
authored
fix: Facebook Limited Login not workind due to incorrect domain in JWT validation (#9120)
1 parent acea93c commit 0e92f76

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

spec/AuthenticationAdapters.spec.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,7 +2081,7 @@ describe('facebook limited auth adapter', () => {
20812081

20822082
it('should use algorithm from key header to verify id_token', async () => {
20832083
const fakeClaim = {
2084-
iss: 'https://facebook.com',
2084+
iss: 'https://www.facebook.com',
20852085
aud: 'secret',
20862086
exp: Date.now(),
20872087
sub: 'the_user_id',
@@ -2145,7 +2145,7 @@ describe('facebook limited auth adapter', () => {
21452145

21462146
it('(using client id as string) should verify id_token', async () => {
21472147
const fakeClaim = {
2148-
iss: 'https://facebook.com',
2148+
iss: 'https://www.facebook.com',
21492149
aud: 'secret',
21502150
exp: Date.now(),
21512151
sub: 'the_user_id',
@@ -2172,7 +2172,7 @@ describe('facebook limited auth adapter', () => {
21722172

21732173
it('(using client id as array) should verify id_token', async () => {
21742174
const fakeClaim = {
2175-
iss: 'https://facebook.com',
2175+
iss: 'https://www.facebook.com',
21762176
aud: 'secret',
21772177
exp: Date.now(),
21782178
sub: 'the_user_id',
@@ -2199,7 +2199,7 @@ describe('facebook limited auth adapter', () => {
21992199

22002200
it('(using client id as array with multiple items) should verify id_token', async () => {
22012201
const fakeClaim = {
2202-
iss: 'https://facebook.com',
2202+
iss: 'https://www.facebook.com',
22032203
aud: 'secret',
22042204
exp: Date.now(),
22052205
sub: 'the_user_id',
@@ -2250,7 +2250,7 @@ describe('facebook limited auth adapter', () => {
22502250
fail();
22512251
} catch (e) {
22522252
expect(e.message).toBe(
2253-
'id token not issued by correct OpenID provider - expected: https://facebook.com | from: https://not.facebook.com'
2253+
'id token not issued by correct OpenID provider - expected: https://www.facebook.com | from: https://not.facebook.com'
22542254
);
22552255
}
22562256
});
@@ -2286,7 +2286,7 @@ describe('facebook limited auth adapter', () => {
22862286
fail();
22872287
} catch (e) {
22882288
expect(e.message).toBe(
2289-
'id token not issued by correct OpenID provider - expected: https://facebook.com | from: https://not.facebook.com'
2289+
'id token not issued by correct OpenID provider - expected: https://www.facebook.com | from: https://not.facebook.com'
22902290
);
22912291
}
22922292
});
@@ -2320,7 +2320,7 @@ describe('facebook limited auth adapter', () => {
23202320
fail();
23212321
} catch (e) {
23222322
expect(e.message).toBe(
2323-
'id token not issued by correct OpenID provider - expected: https://facebook.com | from: https://not.facebook.com'
2323+
'id token not issued by correct OpenID provider - expected: https://www.facebook.com | from: https://not.facebook.com'
23242324
);
23252325
}
23262326
});
@@ -2378,7 +2378,7 @@ describe('facebook limited auth adapter', () => {
23782378

23792379
it('should throw error with with invalid user id', async () => {
23802380
const fakeClaim = {
2381-
iss: 'https://facebook.com',
2381+
iss: 'https://www.facebook.com',
23822382
aud: 'invalid_client_id',
23832383
sub: 'a_different_user_id',
23842384
};

src/Adapters/Auth/facebook.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const jwt = require('jsonwebtoken');
77
const httpsRequest = require('./httpsRequest');
88
const authUtils = require('./utils');
99

10-
const TOKEN_ISSUER = 'https://facebook.com';
10+
const TOKEN_ISSUER = 'https://www.facebook.com';
1111

1212
function getAppSecretPath(authData, options = {}) {
1313
const appSecret = options.appSecret;

0 commit comments

Comments
 (0)