Skip to content

Commit 153655b

Browse files
flovilmartflovilmart
committed
Rebased and nitted
1 parent d2de065 commit 153655b

File tree

1 file changed

+99
-94
lines changed

1 file changed

+99
-94
lines changed

‎spec/Schema.spec.js

Lines changed: 99 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -884,108 +884,113 @@ describe('SchemaController', () => {
884884

885885
describe('Class Level Permissions for requiredAuth', () => {
886886

887+
beforeEach(() => {
888+
config = new Config('test');
889+
});
890+
887891
function createUser() {
888-
let user = new Parse.User();
889-
user.set("username", "hello");
890-
user.set("password", "world");
891-
return user.signUp(null);
892-
}
893-
it_exclude_dbs(['postgres'])('required auth test find', (done) => {
892+
let user = new Parse.User();
893+
user.set("username", "hello");
894+
user.set("password", "world");
895+
return user.signUp(null);
896+
}
897+
898+
it('required auth test find', (done) => {
894899
config.database.loadSchema().then((schema) => {
895-
// Just to create a valid class
896-
return schema.validateObject('Stuff', {foo: 'bar'});
897-
}).then((schema) => {
898-
return schema.setPermissions('Stuff', {
899-
'find': {
900-
'requiresAuthentication': true
901-
}
902-
});
903-
}).then((schema) => {
904-
var query = new Parse.Query('Stuff');
905-
return query.find();
906-
}).then((results) => {
907-
fail('Class permissions should have rejected this query.');
908-
done();
909-
}, (e) => {
910-
expect(e.message).toEqual('Permission denied, user needs to be authenticated.');
911-
done();
900+
// Just to create a valid class
901+
return schema.validateObject('Stuff', {foo: 'bar'});
902+
}).then((schema) => {
903+
return schema.setPermissions('Stuff', {
904+
'find': {
905+
'requiresAuthentication': true
906+
}
912907
});
908+
}).then(() => {
909+
var query = new Parse.Query('Stuff');
910+
return query.find();
911+
}).then(() => {
912+
fail('Class permissions should have rejected this query.');
913+
done();
914+
}, (e) => {
915+
expect(e.message).toEqual('Permission denied, user needs to be authenticated.');
916+
done();
917+
});
913918
});
914919

915-
it_exclude_dbs(['postgres'])('required auth test find authenticated', (done) => {
920+
it('required auth test find authenticated', (done) => {
916921
config.database.loadSchema().then((schema) => {
917-
// Just to create a valid class
918-
return schema.validateObject('Stuff', {foo: 'bar'});
919-
}).then((schema) => {
920-
return schema.setPermissions('Stuff', {
921-
'find': {
922-
'requiresAuthentication': true
923-
}
924-
});
925-
}).then((schema) => {
926-
return createUser();
927-
}).then((user) => {
928-
var query = new Parse.Query('Stuff');
929-
return query.find();
930-
}).then((results) => {
931-
expect(results.length).toEqual(0);
932-
done();
933-
}, (e) => {
934-
console.error(e);
935-
fail("Should not have failed");
936-
done();
922+
// Just to create a valid class
923+
return schema.validateObject('Stuff', {foo: 'bar'});
924+
}).then((schema) => {
925+
return schema.setPermissions('Stuff', {
926+
'find': {
927+
'requiresAuthentication': true
928+
}
937929
});
930+
}).then(() => {
931+
return createUser();
932+
}).then(() => {
933+
var query = new Parse.Query('Stuff');
934+
return query.find();
935+
}).then((results) => {
936+
expect(results.length).toEqual(0);
937+
done();
938+
}, (e) => {
939+
console.error(e);
940+
fail("Should not have failed");
941+
done();
942+
});
938943
});
939944

940-
it_exclude_dbs(['postgres'])('required auth test create authenticated', (done) => {
945+
it('required auth should allow create authenticated', (done) => {
941946
config.database.loadSchema().then((schema) => {
942-
// Just to create a valid class
943-
return schema.validateObject('Stuff', {foo: 'bar'});
944-
}).then((schema) => {
945-
return schema.setPermissions('Stuff', {
946-
'create': {
947-
'requiresAuthentication': true
948-
}
949-
});
950-
}).then((schema) => {
951-
return createUser();
952-
}).then((user) => {
953-
let stuff = new Parse.Object('Stuff');
954-
stuff.set('foo', 'bar');
955-
return stuff.save();
956-
}).then((savedObject) => {
957-
done();
958-
}, (e) => {
959-
console.error(e);
960-
fail("Should not have failed");
961-
done();
947+
// Just to create a valid class
948+
return schema.validateObject('Stuff', {foo: 'bar'});
949+
}).then((schema) => {
950+
return schema.setPermissions('Stuff', {
951+
'create': {
952+
'requiresAuthentication': true
953+
}
962954
});
955+
}).then(() => {
956+
return createUser();
957+
}).then(() => {
958+
let stuff = new Parse.Object('Stuff');
959+
stuff.set('foo', 'bar');
960+
return stuff.save();
961+
}).then(() => {
962+
done();
963+
}, (e) => {
964+
console.error(e);
965+
fail("Should not have failed");
966+
done();
967+
});
963968
});
964969

965-
it_exclude_dbs(['postgres'])('required auth test create authenticated', (done) => {
970+
it('required auth should reject create when not authenticated', (done) => {
966971
config.database.loadSchema().then((schema) => {
967-
// Just to create a valid class
968-
return schema.validateObject('Stuff', {foo: 'bar'});
969-
}).then((schema) => {
970-
return schema.setPermissions('Stuff', {
971-
'create': {
972-
'requiresAuthentication': true
973-
}
974-
});
975-
}).then((user) => {
976-
let stuff = new Parse.Object('Stuff');
977-
stuff.set('foo', 'bar');
978-
return stuff.save();
979-
}).then((results) => {
980-
fail('Class permissions should have rejected this query.');
981-
done();
982-
}, (e) => {
983-
expect(e.message).toEqual('Permission denied, user needs to be authenticated.');
984-
done();
972+
// Just to create a valid class
973+
return schema.validateObject('Stuff', {foo: 'bar'});
974+
}).then((schema) => {
975+
return schema.setPermissions('Stuff', {
976+
'create': {
977+
'requiresAuthentication': true
978+
}
985979
});
980+
}).then(() => {
981+
let stuff = new Parse.Object('Stuff');
982+
stuff.set('foo', 'bar');
983+
return stuff.save();
984+
}).then(() => {
985+
fail('Class permissions should have rejected this query.');
986+
done();
987+
}, (e) => {
988+
expect(e.message).toEqual('Permission denied, user needs to be authenticated.');
989+
done();
990+
});
986991
});
987992

988-
it_exclude_dbs(['postgres'])('required auth test create/get/update/delete authenticated', (done) => {
993+
it('required auth test create/get/update/delete authenticated', (done) => {
989994
config.database.loadSchema().then((schema) => {
990995
// Just to create a valid class
991996
return schema.validateObject('Stuff', {foo: 'bar'});
@@ -1004,9 +1009,9 @@ describe('Class Level Permissions for requiredAuth', () => {
10041009
'requiresAuthentication': true
10051010
}
10061011
});
1007-
}).then((schema) => {
1012+
}).then(() => {
10081013
return createUser();
1009-
}).then((user) => {
1014+
}).then(() => {
10101015
let stuff = new Parse.Object('Stuff');
10111016
stuff.set('foo', 'bar');
10121017
return stuff.save().then(() => {
@@ -1015,7 +1020,7 @@ describe('Class Level Permissions for requiredAuth', () => {
10151020
});
10161021
}).then((gotStuff) => {
10171022
return gotStuff.save({'foo': 'baz'}).then(() => {
1018-
return gotStuff.destroy();
1023+
return gotStuff.destroy();
10191024
})
10201025
}).then(() => {
10211026
done();
@@ -1026,7 +1031,7 @@ describe('Class Level Permissions for requiredAuth', () => {
10261031
});
10271032
});
10281033

1029-
it_exclude_dbs(['postgres'])('required auth test create/get/update/delete not authenitcated', (done) => {
1034+
it('required auth test create/get/update/delete not authenitcated', (done) => {
10301035
config.database.loadSchema().then((schema) => {
10311036
// Just to create a valid class
10321037
return schema.validateObject('Stuff', {foo: 'bar'});
@@ -1045,14 +1050,14 @@ describe('Class Level Permissions for requiredAuth', () => {
10451050
'*': true
10461051
}
10471052
});
1048-
}).then((user) => {
1053+
}).then(() => {
10491054
let stuff = new Parse.Object('Stuff');
10501055
stuff.set('foo', 'bar');
10511056
return stuff.save().then(() => {
10521057
let query = new Parse.Query('Stuff');
10531058
return query.get(stuff.id);
10541059
});
1055-
}).then((res) => {
1060+
}).then(() => {
10561061
fail("Should not succeed!");
10571062
done();
10581063
}, (e) => {
@@ -1061,7 +1066,7 @@ describe('Class Level Permissions for requiredAuth', () => {
10611066
});
10621067
});
10631068

1064-
it_exclude_dbs(['postgres'])('required auth test create/get/update/delete not authenitcated', (done) => {
1069+
it('required auth test create/get/update/delete not authenitcated', (done) => {
10651070
config.database.loadSchema().then((schema) => {
10661071
// Just to create a valid class
10671072
return schema.validateObject('Stuff', {foo: 'bar'});
@@ -1083,7 +1088,7 @@ describe('Class Level Permissions for requiredAuth', () => {
10831088
'*': true
10841089
}
10851090
});
1086-
}).then((user) => {
1091+
}).then(() => {
10871092
let stuff = new Parse.Object('Stuff');
10881093
stuff.set('foo', 'bar');
10891094
return stuff.save().then(() => {
@@ -1094,7 +1099,7 @@ describe('Class Level Permissions for requiredAuth', () => {
10941099
expect(result.get('foo')).toEqual('bar');
10951100
let query = new Parse.Query('Stuff');
10961101
return query.find();
1097-
}).then((res) => {
1102+
}).then(() => {
10981103
fail("Should not succeed!");
10991104
done();
11001105
}, (e) => {

0 commit comments

Comments
 (0)