rename

Author: dblythy

spec/CloudCode.spec.js

@@ -1598,15 +1598,15 @@ describe('Cloud Code', () => {
     expect(obj.get('count')).toBe(0);
   });
 
-  it('Pointer should not be cleared by triggers', async () => {
+  it('pointer should not be cleared by triggers', async () => {
     Parse.Cloud.afterSave('MyObject', () => {});
     const foo = await new Parse.Object('Test', { foo: 'bar' }).save();
     const obj = await new Parse.Object('MyObject', { foo }).save();
     const foo2 = obj.get('foo');
     expect(foo2.get('foo')).toBe('bar');
   });
 
-  it('Can set a pointer in triggers', async () => {
+  it('can set a pointer in triggers', async () => {
     Parse.Cloud.beforeSave('MyObject', () => {});
     Parse.Cloud.afterSave(
       'MyObject',

src/Controllers/SchemaController.js

@@ -150,14 +150,16 @@ const defaultColumns: { [string]: SchemaFields } = Object.freeze({
   },
 });
 
-const requiredColumnsForWrite = Object.freeze({
-  _Product: ['productIdentifier', 'icon', 'order', 'title', 'subtitle'],
-  _Role: ['name', 'ACL'],
+const requiredColumns = Object.freeze({
+  read: {
+    _User: ['username'],
+  },
+  write: {
+    _Product: ['productIdentifier', 'icon', 'order', 'title', 'subtitle'],
+    _Role: ['name', 'ACL'],
+  }
 });
 
-const requiredColumnsForRead = Object.freeze({
-  _User: ['username'],
-});
 
 const invalidColumns = ['length'];
 
@@ -1273,7 +1275,7 @@ export default class SchemaController {
 
   // Validates that all the properties are set for the object
   validateRequiredColumns(className: string, object: any, query: any) {
-    const columns = requiredColumnsForWrite[className];
+    const columns = requiredColumns.write[className];
     if (!columns || columns.length == 0) {
       return Promise.resolve(this);
     }
@@ -1604,5 +1606,5 @@ export {
   convertSchemaToAdapterSchema,
   VolatileClassesSchemas,
   SchemaController,
-  requiredColumnsForRead,
+  requiredColumns,
 };

src/RestWrite.js

@@ -15,7 +15,7 @@ var ClientSDK = require('./ClientSDK');
 import RestQuery from './RestQuery';
 import _ from 'lodash';
 import logger from './logger';
-import { requiredColumnsForRead } from './Controllers/SchemaController';
+import { requiredColumns } from './Controllers/SchemaController';
 
 // query and data are both provided in REST API format. So data
 // types are encoded by plain old objects.
@@ -1670,7 +1670,7 @@ RestWrite.prototype._updateResponseWithData = function (response, data) {
     'objectId',
     'createdAt',
     'updatedAt',
-    ...(requiredColumnsForRead[this.className] || []),
+    ...(requiredColumns.read[this.className] || []),
   ];
   for (const key in response) {
     if (skipKeys.includes(key)) {