log on error

Author: dblythy

spec/CloudCode.spec.js

@@ -3186,13 +3186,11 @@ describe('sendMail', () => {
   });
 
   it('cannot send email without adapter', async () => {
-    try {
-      await Parse.Cloud.sendMail({});
-      fail('Should have failed to send emails.');
-    } catch (e) {
-      expect(e).toBe(
-        'Failed to send email because no mail adapter is configured for Parse Server.'
-      );
-    }
+    const logger = require('../lib/logger').logger;
+    spyOn(logger, 'warn').and.callFake(() => {});
+    await Parse.Cloud.sendMail({});
+    expect(logger.warn).toHaveBeenCalledWith(
+      'Failed to send email because no mail adapter is configured for Parse Server.'
+    );
   });
 });

src/cloud-code/Parse.Cloud.js

@@ -551,10 +551,12 @@ ParseCloud.beforeConnect = function (handler, validationHandler) {
 ParseCloud.sendMail = function (data) {
   const config = Config.get(Parse.applicationId) || {};
   const emailAdapter = config.userController.adapter;
-  if (!emailAdapter) {
-    throw 'Failed to send email because no mail adapter is configured for Parse Server.';
+  if (emailAdapter) {
+    return emailAdapter.sendMail(data);
   }
-  return emailAdapter.sendMail(data);
+  config.loggerController.warn(
+    'Failed to send email because no mail adapter is configured for Parse Server.'
+  );
 };
 
 /**