Skip to content

Commit 2ec03d4

Browse files
committed
wip
1 parent a467398 commit 2ec03d4

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

spec/ParseLiveQuery.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ describe('ParseLiveQuery', function () {
401401
startLiveQueryServer: true,
402402
});
403403
const query = new Parse.Query('Test');
404-
query.triggerFields('yolo');
404+
query.listen('yolo');
405405
const subscription = await query.subscribe();
406406
const spy = {
407407
create(obj) {

spec/ParseLiveQueryServer.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,7 +1087,7 @@ describe('ParseLiveQueryServer', function () {
10871087
done();
10881088
});
10891089

1090-
it('can handle create command with triggerFields', async () => {
1090+
it('can handle create command with listen', async () => {
10911091
jasmine.restoreLibrary('../lib/LiveQuery/Client', 'Client');
10921092
const Client = require('../lib/LiveQuery/Client').Client;
10931093
const parseLiveQueryServer = new ParseLiveQueryServer({});
@@ -1110,7 +1110,7 @@ describe('ParseLiveQueryServer', function () {
11101110
where: {
11111111
key: 'value',
11121112
},
1113-
triggerFields: ['yolo'],
1113+
listen: ['yolo'],
11141114
};
11151115
await addMockSubscription(parseLiveQueryServer, clientId, requestId, parseWebSocket, query);
11161116
// Mock _matchesSubscription to return matching

src/LiveQuery/ParseLiveQueryServer.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import { getCacheController, getDatabaseController } from '../Controllers';
2222
import LRU from 'lru-cache';
2323
import UserRouter from '../Routers/UsersRouter';
2424
import DatabaseController from '../Controllers/DatabaseController';
25+
import { isDeepStrictEqual } from 'util';
2526

2627
class ParseLiveQueryServer {
2728
clients: Map;
@@ -329,8 +330,8 @@ class ParseLiveQueryServer {
329330
} else {
330331
return null;
331332
}
332-
const triggerFieldsChanged = this._checkTriggerFields(client, requestId, message);
333-
if (!triggerFieldsChanged && (type === 'update' || type === 'create')) {
333+
const listenFieldsChanged = this._checkListenFields(client, requestId, message);
334+
if (!listenFieldsChanged && (type === 'update' || type === 'create')) {
334335
return;
335336
}
336337
res = {
@@ -710,15 +711,15 @@ class ParseLiveQueryServer {
710711
return auth;
711712
}
712713

713-
_checkTriggerFields(client: any, requestId: any, message: any) {
714+
_checkListenFields(client: any, requestId: any, message: any) {
714715
const subscriptionInfo = client.getSubscriptionInfo(requestId);
715-
const triggerFields = subscriptionInfo?.triggerFields;
716-
if (!triggerFields) {
716+
const listen = subscriptionInfo?.listen;
717+
if (!listen) {
717718
return true;
718719
}
719720
const object = message.currentParseObject;
720721
const original = message.originalParseObject;
721-
return triggerFields.some(field => !_.isEqual(object.get(field), original?.get(field)));
722+
return listen.some(field => !isDeepStrictEqual(object.get(field), original?.get(field)));
722723
}
723724

724725
async _matchesACL(acl: any, client: any, requestId: number): Promise<boolean> {
@@ -902,8 +903,8 @@ class ParseLiveQueryServer {
902903
if (request.query.fields) {
903904
subscriptionInfo.fields = request.query.fields;
904905
}
905-
if (request.query.triggerFields) {
906-
subscriptionInfo.triggerFields = request.query.triggerFields;
906+
if (request.query.listen) {
907+
subscriptionInfo.listen = request.query.listen;
907908
}
908909
if (request.sessionToken) {
909910
subscriptionInfo.sessionToken = request.sessionToken;

0 commit comments

Comments
 (0)