Adds tests for logging configuration

Author: flovilmart

spec/Logger.spec.js

@@ -8,7 +8,6 @@ class TestTransport extends winston.Transport {
 }
 
 describe('Logger', () => {
-  // Test is excluded as will be refactored
   it('should add transport', () => {
     const testTransport = new (TestTransport)({
       name: 'test'
@@ -19,4 +18,45 @@ describe('Logger', () => {
     expect(testTransport.log).toHaveBeenCalled();
     logging.removeTransport(testTransport);
   });
+
+  it('should have files transports', (done) => {
+    reconfigureServer().then(() => {
+      let transports = logging.logger.transports;
+      let transportKeys = Object.keys(transports);
+      expect(transportKeys.length).toBe(2);
+      done();
+    });
+  });
+
+  it('should disable files logs', (done) => {
+    reconfigureServer({
+      logsFolder: null
+    }).then(() => {
+      let transports = logging.logger.transports;
+      let transportKeys = Object.keys(transports);
+      expect(transportKeys.length).toBe(0);
+      done();
+    });
+  });
+
+  it('should enable JSON logs', (done) => {
+    // Force console transport
+    process.env.VERBOSE=1;
+    reconfigureServer({
+      logsFolder: null,
+      jsonLogs: true
+    }).then(() => {
+      let spy = spyOn(process.stdout, 'write');
+      logging.logger.info('hi', {key: 'value'});
+      expect(process.stdout.write).toHaveBeenCalled();
+      var firstLog = process.stdout.write.calls.first().args[0];
+      expect(firstLog).toEqual(JSON.stringify({key: 'value', level: 'info', message: 'hi' })+'\n');
+      delete process.env.VERBOSE;
+      return reconfigureServer({
+        jsonLogs: false
+      });
+    }).then(() => {
+      done();
+    });
+  });
 });

src/Adapters/Logger/WinstonLogger.js

@@ -14,7 +14,7 @@ function updateTransports(options) {
     if (_.isNull(options.dirname)) {
       delete transports['parse-server'];
       delete transports['parse-server-error'];
-    } else if (!_.isUndefined(options.dirname)) {
+    } else {
       transports['parse-server'] = new (DailyRotateFile)(
         Object.assign({
           filename: 'parse-server.info',
@@ -34,6 +34,8 @@ function updateTransports(options) {
           colorize: true,
           name: 'console'
         }, options));
+    } else {
+      delete transports['console'];
     }
   }
   // Mount the additional transports
@@ -86,7 +88,10 @@ export function removeTransport(transport) {
   delete transports[transportName];
   logger.configure({
     transports: _.values(transports)
-  })
+  });
+  _.remove(additionalTransports, (transport) => {
+    return transport.name === transportName;
+  });
 }
 
 export { logger, addTransport, configureLogger, removeTransport };