Move logic to it's own function and use it for appId and masterKey as well.

Author: drew-gross

spec/index.spec.js

@@ -2,23 +2,9 @@ var request = require('request');
 
 describe('server', () => {
   it('requires a master key and app id', done => {
-    expect(setServerConfiguration.bind(undefined, { masterKey: 'mykey', serverURL: '' })).toThrow('You must provide an appId and masterKey!');
-    expect(setServerConfiguration.bind(undefined, { appId: 'myId', serverURL: '' })).toThrow('You must provide an appId and masterKey!');
-    done();
-  });
-
-  it('requires a serverURL', done => {
-    expect(setServerConfiguration.bind(undefined, {
-      databaseURI: 'mongodb://fake:[email protected]:43605/drew3',
-      appId: 'test',
-      javascriptKey: 'test',
-      dotNetKey: 'windows',
-      clientKey: 'client',
-      restAPIKey: 'rest',
-      masterKey: 'test',
-      collectionPrefix: 'test_',
-      fileKey: 'test',
-    })).toThrow('You must provide a serverURL!');
+    expect(setServerConfiguration.bind(undefined, {  })).toThrow('You must provide an appId!');
+    expect(setServerConfiguration.bind(undefined, { appId: 'myId' })).toThrow('You must provide a masterKey!');
+    expect(setServerConfiguration.bind(undefined, { appId: 'myId', masterKey: 'mk' })).toThrow('You must provide a serverURL!');
     done();
   });
 

src/index.js

@@ -37,6 +37,7 @@ import { loadAdapter }         from './Adapters/AdapterLoader';
 import { FileLoggerAdapter }   from './Adapters/Logger/FileLoggerAdapter';
 import { LoggerController }    from './Controllers/LoggerController';
 
+import requiredParameter       from './requiredParameter';
 // Mutate the Parse object to add the Cloud Code handlers
 addParseCloud();
 
@@ -65,8 +66,8 @@ addParseCloud();
 // "push": optional key from configure push
 
 function ParseServer({
-  appId,
-  masterKey,
+  appId = requiredParameter('You must provide an appId!'),
+  masterKey = requiredParameter('You must provide a masterKey!'),
   databaseAdapter,
   filesAdapter,
   push,
@@ -82,12 +83,8 @@ function ParseServer({
   facebookAppIds = [],
   enableAnonymousUsers = true,
   oauth = {},
-  serverURL = (()=>{throw 'You must provide a serverURL!'})(),
+  serverURL = requiredParameter('You must provide a serverURL!'),
 }) {
-  if (!appId || !masterKey) {
-    throw 'You must provide an appId and masterKey!';
-  }
-
   if (databaseAdapter) {
     DatabaseAdapter.setAdapter(databaseAdapter);
   }

src/requiredParameter.js

@@ -0,0 +1,2 @@
+/* @flow */
+export default (errorMessage: string) => {throw errorMessage}