Skip to content

Commit 56462c8

Browse files
committed
improve tests
1 parent 60bbd42 commit 56462c8

File tree

3 files changed

+14
-23
lines changed

3 files changed

+14
-23
lines changed

spec/CloudCode.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ describe('Cloud Code', () => {
225225
obj.set('foo', 'bar');
226226
try {
227227
await obj.save();
228-
expect(false).toBe(true);
228+
fail('should not succeed');
229229
} catch (e) {
230230
expect(e.message).toBe('Invalid field name: length.');
231231
}

spec/ParseObject.spec.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -728,15 +728,19 @@ describe('Parse.Object testing', () => {
728728
});
729729
});
730730

731-
it('cannot save object with className field', async () => {
732-
const obj = new TestObject();
733-
obj.set('className', 'bar');
734-
try {
735-
await obj.save();
736-
expect(true).toBe(false);
737-
} catch (e) {
738-
expect(e.message).toBe('Invalid field name: className.');
739-
}
731+
it('cannot save object with invalid field', async () => {
732+
const invalidFields = ['className', 'length'];
733+
const promises = invalidFields.map(async field => {
734+
const obj = new TestObject();
735+
obj.set(field, 'bar');
736+
try {
737+
await obj.save();
738+
fail('should not succeed');
739+
} catch (e) {
740+
expect(e.message).toBe(`Invalid field name: ${field}.`);
741+
}
742+
});
743+
await Promise.all(promises);
740744
});
741745

742746
it('old attribute unset then unset', function (done) {

spec/ParseQuery.spec.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2860,19 +2860,6 @@ describe('Parse.Query testing', () => {
28602860
});
28612861
});
28622862

2863-
it('object with length', async () => {
2864-
const TestObject = Parse.Object.extend('TestObject');
2865-
const obj = new TestObject();
2866-
obj.set('length', 5);
2867-
equal(obj.get('length'), 5);
2868-
try {
2869-
await obj.save();
2870-
expect(false).toBe(true);
2871-
} catch (e) {
2872-
expect(e.message).toBe('Invalid field name: length.');
2873-
}
2874-
});
2875-
28762863
it('include user', function (done) {
28772864
Parse.User.signUp('bob', 'password', { age: 21 }).then(function (user) {
28782865
const TestObject = Parse.Object.extend('TestObject');

0 commit comments

Comments
 (0)