Skip to content

Commit 5814437

Browse files
committed
Merge remote-tracking branch 'upstream/alpha' into alpha
2 parents 3c8f5cc + 5908a40 commit 5814437

File tree

14 files changed

+272
-136
lines changed

14 files changed

+272
-136
lines changed

.github/workflows/ci.yml

Lines changed: 36 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66
branches: [ release, alpha, beta ]
77
env:
8-
NODE_VERSION: 16.14.2
8+
NODE_VERSION: 18.1.0
99
PARSE_SERVER_TEST_TIMEOUT: 20000
1010
jobs:
1111
check-code-analysis:
@@ -121,47 +121,37 @@ jobs:
121121
strategy:
122122
matrix:
123123
include:
124-
- name: MongoDB 5.2, ReplicaSet, WiredTiger
125-
MONGODB_VERSION: 5.2.1
126-
MONGODB_TOPOLOGY: replicaset
127-
MONGODB_STORAGE_ENGINE: wiredTiger
128-
NODE_VERSION: 14.19.1
129-
- name: MongoDB 5.1, ReplicaSet, WiredTiger
130-
MONGODB_VERSION: 5.1.1
124+
- name: MongoDB 4.0, Standalone, MMAPv1
125+
MONGODB_VERSION: 4.0.28
126+
MONGODB_TOPOLOGY: standalone
127+
MONGODB_STORAGE_ENGINE: mmapv1
128+
NODE_VERSION: 18.1.0
129+
- name: MongoDB 4.0, ReplicaSet, WiredTiger
130+
MONGODB_VERSION: 4.0.28
131131
MONGODB_TOPOLOGY: replicaset
132132
MONGODB_STORAGE_ENGINE: wiredTiger
133-
NODE_VERSION: 14.19.1
134-
- name: MongoDB 5.0, ReplicaSet, WiredTiger
135-
MONGODB_VERSION: 5.0.6
133+
NODE_VERSION: 18.1.0
134+
- name: MongoDB 4.2, ReplicaSet, WiredTiger
135+
MONGODB_VERSION: 4.2.19
136136
MONGODB_TOPOLOGY: replicaset
137137
MONGODB_STORAGE_ENGINE: wiredTiger
138-
NODE_VERSION: 16.14.2
138+
NODE_VERSION: 18.1.0
139139
- name: MongoDB 4.4, ReplicaSet, WiredTiger
140140
MONGODB_VERSION: 4.4.13
141141
MONGODB_TOPOLOGY: replicaset
142142
MONGODB_STORAGE_ENGINE: wiredTiger
143-
NODE_VERSION: 16.14.2
144-
- name: MongoDB 4.2, ReplicaSet, WiredTiger
145-
MONGODB_VERSION: 4.2.19
146-
MONGODB_TOPOLOGY: replicaset
147-
MONGODB_STORAGE_ENGINE: wiredTiger
148-
NODE_VERSION: 16.14.2
149-
- name: MongoDB 4.0, ReplicaSet, WiredTiger
150-
MONGODB_VERSION: 4.0.28
143+
NODE_VERSION: 18.1.0
144+
- name: MongoDB 5.3, ReplicaSet, WiredTiger
145+
MONGODB_VERSION: 5.3.2
151146
MONGODB_TOPOLOGY: replicaset
152147
MONGODB_STORAGE_ENGINE: wiredTiger
153-
NODE_VERSION: 16.14.2
154-
- name: MongoDB 4.0, Standalone, MMAPv1
155-
MONGODB_VERSION: 4.0.28
156-
MONGODB_TOPOLOGY: standalone
157-
MONGODB_STORAGE_ENGINE: mmapv1
158-
NODE_VERSION: 16.14.2
148+
NODE_VERSION: 18.1.0
159149
- name: Redis Cache
160150
PARSE_SERVER_TEST_CACHE: redis
161151
MONGODB_VERSION: 4.4.13
162152
MONGODB_TOPOLOGY: standalone
163153
MONGODB_STORAGE_ENGINE: wiredTiger
164-
NODE_VERSION: 16.14.2
154+
NODE_VERSION: 18.1.0
165155
- name: Node 12
166156
MONGODB_VERSION: 4.4.13
167157
MONGODB_TOPOLOGY: standalone
@@ -172,16 +162,16 @@ jobs:
172162
MONGODB_TOPOLOGY: standalone
173163
MONGODB_STORAGE_ENGINE: wiredTiger
174164
NODE_VERSION: 14.19.1
175-
- name: Node 17
165+
- name: Node 16
176166
MONGODB_VERSION: 4.4.13
177167
MONGODB_TOPOLOGY: standalone
178168
MONGODB_STORAGE_ENGINE: wiredTiger
179-
NODE_VERSION: 17.9.0
180-
- name: Node 18
169+
NODE_VERSION: 16.14.2
170+
- name: Node 17
181171
MONGODB_VERSION: 4.4.13
182172
MONGODB_TOPOLOGY: standalone
183173
MONGODB_STORAGE_ENGINE: wiredTiger
184-
NODE_VERSION: 18.1.0
174+
NODE_VERSION: 17.9.0
185175
fail-fast: false
186176
name: ${{ matrix.name }}
187177
timeout-minutes: 15
@@ -225,22 +215,25 @@ jobs:
225215
include:
226216
- name: PostgreSQL 11, PostGIS 3.0
227217
POSTGRES_IMAGE: postgis/postgis:11-3.0
228-
NODE_VERSION: 16.14.2
218+
NODE_VERSION: 18.1.0
229219
- name: PostgreSQL 11, PostGIS 3.1
230220
POSTGRES_IMAGE: postgis/postgis:11-3.1
231-
NODE_VERSION: 16.14.2
221+
NODE_VERSION: 18.1.0
232222
- name: PostgreSQL 11, PostGIS 3.2
233223
POSTGRES_IMAGE: postgis/postgis:11-3.2
234-
NODE_VERSION: 16.14.2
235-
- name: PostgreSQL 12, PostGIS 3.2
236-
POSTGRES_IMAGE: postgis/postgis:12-3.2
237-
NODE_VERSION: 16.14.2
238-
- name: PostgreSQL 13, PostGIS 3.2
239-
POSTGRES_IMAGE: postgis/postgis:13-3.2
240-
NODE_VERSION: 16.14.2
241-
- name: PostgreSQL 14, PostGIS 3.2
242-
POSTGRES_IMAGE: postgis/postgis:14-3.2
243-
NODE_VERSION: 16.14.2
224+
NODE_VERSION: 18.1.0
225+
- name: PostgreSQL 11, PostGIS 3.3
226+
POSTGRES_IMAGE: postgis/postgis:11-3.3
227+
NODE_VERSION: 18.1.0
228+
- name: PostgreSQL 12, PostGIS 3.3
229+
POSTGRES_IMAGE: postgis/postgis:12-3.3
230+
NODE_VERSION: 18.1.0
231+
- name: PostgreSQL 13, PostGIS 3.3
232+
POSTGRES_IMAGE: postgis/postgis:13-3.3
233+
NODE_VERSION: 18.1.0
234+
- name: PostgreSQL 14, PostGIS 3.3
235+
POSTGRES_IMAGE: postgis/postgis:14-3.3
236+
NODE_VERSION: 18.1.0
244237
fail-fast: false
245238
name: ${{ matrix.name }}
246239
timeout-minutes: 15

CONTRIBUTING.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,14 @@
22

33
## Table of Contents <!-- omit in toc -->
44
- [Contributing](#contributing)
5+
- [Issue vs. Pull Request](#issue-vs-pull-request)
56
- [Templates](#templates)
67
- [Why Contributing?](#why-contributing)
8+
- [Contribution FAQs](#contribution-faqs)
9+
- [Reviewer Role](#reviewer-role)
10+
- [Review Feedback](#review-feedback)
11+
- [Merge Readiness](#merge-readiness)
12+
- [Review Validity](#review-validity)
713
- [Environment Setup](#environment-setup)
814
- [Recommended Tools](#recommended-tools)
915
- [Setting up your local machine](#setting-up-your-local-machine)
@@ -87,6 +93,42 @@ Consider the benefits you get:
8793

8894
Most importantly, with every contribution you improve your skills so that future contributions take even less time and you get all the benefits above for free — easy choice, right?
8995

96+
## Contribution FAQs
97+
98+
### Reviewer Role
99+
100+
> *Instead of writing review comments back-and-forth, why doesn't the reviewer just write the code themselves?*
101+
102+
A reviewer is already helping you to make a code contribution through their review. A reviewer *may* even help you to write code by actually writing it for you, but is not obliged to do so.
103+
104+
### Review Feedback
105+
106+
> *It takes too much effort to incorporate the review feedback, why why can't you just merge my pull request?*
107+
108+
If you are a new contributor, it's naturally a learning experience for you and therefore takes longer. We welcome contributors of any experience levels and gladly support you in getting familiar with the code base and our quality standards and contribution requirements. In return we expect you to be open to and appreciative of the reviewers' feedback.
109+
110+
In a large pull request, it can be a significant effort to bring it over the finish line. Luckily this is a collaborative environment and others are free to jump in to contribute to the pull request to share the effort. You can either give others access to your fork or they can open their own pull request based on your previous work.
111+
112+
If you are out of resources stay calm, explain your personal constraints (expertise or time) and ask for help. Wasting time by complaining about the amount of review comments will neither use your own time in a meaningful way, nor the time of others who read your complaint.
113+
114+
**❗️ Always be mindful that the reviewers' efforts are an integral part of code contribution. Their review is as important as your written code and their review time is a valuable as your coding time.**
115+
116+
### Merge Readiness
117+
118+
> *The feature already works, why do you request more changes instead of just merging my pull request?*
119+
120+
A feature may work for your own use case or in your own environment, but that doesn't necessarily mean that it's ready for merging. Aside from code quality and code style requirements, reviewers also review based on strategic and architectural considerations. It's often easy to just get a feature to work, but it needs to be also maintained in the future, robust therefore well tested and validated, intuitive for other developers to use, well documented, and not cause a forseeable breaking change in the near future.
121+
122+
### Review Validity
123+
124+
> *The reviewer has never worked on the issue and was never part of any previous discussion, why would I care about their opinion?*
125+
126+
It's contrary to an open, collaborative environment to expect others to be involved in an issue or discussion since its beginning. Such a mindset would close out any new views from other people, which are important for a differentiated view.
127+
128+
> *The reviewer doesn't have any expertise in that matter, why would I care about their opinion?*
129+
130+
Your arguments must focus on the issue, not on your assumption of someone else's personal experience. We will take immediate and appropriate action in case of personal attacks, regardless of your previous contributions. Personal attacks are not permissible. If you are a reviewer who became a victim of personal attacks, you can privately [report](https://docs.github.com/en/communities/maintaining-your-safety-on-github/reporting-abuse-or-spam) the GitHub comment to the PMC.
131+
90132
## Environment Setup
91133

92134
### Recommended Tools

README.md

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ The full documentation for Parse Server is available in the [wiki](https://githu
3232

3333
A big *thank you* 🙏 to our [sponsors](#sponsors) and [backers](#backers) who support the development of Parse Platform!
3434

35-
### Diamond Sponsors
36-
37-
[![Diamond Sponsors](https://opencollective.com/parse-server/tiers/diamond-sponsor.svg?avatarHeight=70&button=false)](https://opencollective.com/parse-server/contribute/diamond-sponsor-10560)
38-
3935
#### Bronze Sponsors
4036

4137
[![Bronze Sponsors](https://opencollective.com/parse-server/tiers/bronze-sponsor.svg?avatarHeight=36&button=false)](https://opencollective.com/parse-server/contribute/bronze-sponsor-10559)
@@ -138,27 +134,26 @@ Parse Server is continuously tested with the most recent releases of Node.js to
138134

139135
#### MongoDB
140136

141-
Parse Server is continuously tested with the most recent releases of MongoDB to ensure compatibility. We follow the [MongoDB support schedule](https://www.mongodb.com/support-policy) and only test against versions that are officially supported and have not reached their end-of-life date.
137+
Parse Server is continuously tested with the most recent releases of MongoDB to ensure compatibility. We follow the [MongoDB support schedule](https://www.mongodb.com/support-policy) and [MongoDB lifecycle schedule](https://www.mongodb.com/support-policy/lifecycles) and only test against versions that are officially supported and have not reached their end-of-life date. We consider the end-of-life date of a MongoDB "rapid release" to be the same as its major version release.
142138

143-
| Version | Latest Version | End-of-Life | Compatible |
144-
|-------------|----------------|-------------|------------|
145-
| MongoDB 4.0 | 4.0.28 | April 2022 | ✅ Yes |
146-
| MongoDB 4.2 | 4.2.19 | TBD | ✅ Yes |
147-
| MongoDB 4.4 | 4.4.13 | TBD | ✅ Yes |
148-
| MongoDB 5.0 | 5.0.6 | TBD | ✅ Yes |
149-
| MongoDB 5.1 | 5.1.1 | TBD | ✅ Yes |
150-
| MongoDB 5.2 | 5.2.1 | TBD | ✅ Yes |
139+
| Version | Latest Version | End-of-Life | Compatible |
140+
|-------------|----------------|---------------|--------------|
141+
| MongoDB 4.0 | 4.0.28 | April 2022 | ✅ Yes |
142+
| MongoDB 4.2 | 4.2.19 | April 2023 | ✅ Yes |
143+
| MongoDB 4.4 | 4.4.13 | February 2024 | ✅ Yes |
144+
| MongoDB 5.3 | 5.3.2 | October 2024 | ✅ Yes |
145+
| MongoDB 6.0 | - | July 2025 | ❌ Not tested |
151146

152147
#### PostgreSQL
153148

154-
Parse Server is continuously tested with the most recent releases of PostgreSQL and PostGIS to ensure compatibility, using [PostGIS docker images](https://registry.hub.docker.com/r/postgis/postgis/tags?page=1&ordering=last_updated). We follow the [PostgreSQL support schedule](https://www.postgresql.org/support/versioning) and [PostGIS support schedule](https://www.postgis.net/eol_policy/) and only test against versions that are officially supported and have not reached their end-of-life date. Due to the extensive PostgreSQL support duration of 5 years, Parse Server drops support if a version is older than 3.5 years and a newer version has been available for at least 2.5 years.
149+
Parse Server is continuously tested with the most recent releases of PostgreSQL and PostGIS to ensure compatibility, using [PostGIS docker images](https://registry.hub.docker.com/r/postgis/postgis/tags?page=1&ordering=last_updated). We follow the [PostgreSQL support schedule](https://www.postgresql.org/support/versioning) and [PostGIS support schedule](https://www.postgis.net/eol_policy/) and only test against versions that are officially supported and have not reached their end-of-life date. Due to the extensive PostgreSQL support duration of 5 years, Parse Server drops support about 2 years before the official end-of-life date.
155150

156-
| Version | PostGIS Version | End-of-Life | Parse Server Support End | Compatible |
157-
|-------------|-----------------|---------------|--------------------------|------------|
158-
| Postgres 11 | 3.0, 3.1, 3.2 | November 2023 | April 2022 | ✅ Yes |
159-
| Postgres 12 | 3.2 | November 2024 | April 2023 | ✅ Yes |
160-
| Postgres 13 | 3.2 | November 2025 | April 2024 | ✅ Yes |
161-
| Postgres 14 | 3.2 | November 2026 | April 2025 | ✅ Yes |
151+
| Version | PostGIS Version | End-of-Life | Parse Server Support | Compatible |
152+
|-------------|--------------------|---------------|----------------------|------------|
153+
| Postgres 11 | 3.0, 3.1, 3.2, 3.3 | November 2023 | <= 5.x (2022) | ✅ Yes |
154+
| Postgres 12 | 3.3 | November 2024 | <= 5.x (2022) | ✅ Yes |
155+
| Postgres 13 | 3.3 | November 2025 | <= 6.x (2023) | ✅ Yes |
156+
| Postgres 14 | 3.3 | November 2026 | <= 7.x (2024) | ✅ Yes |
162157

163158
### Locally
164159

@@ -1186,4 +1181,4 @@ As of April 5, 2017, Parse, LLC has transferred this code to the parse-community
11861181
[open-collective-link]: https://opencollective.com/parse-server
11871182
[log_release]: https://github.com/parse-community/parse-server/blob/release/changelogs/CHANGELOG_release.md
11881183
[log_beta]: https://github.com/parse-community/parse-server/blob/beta/changelogs/CHANGELOG_beta.md
1189-
[log_alpha]: https://github.com/parse-community/parse-server/blob/alpha/changelogs/CHANGELOG_alpha.md
1184+
[log_alpha]: https://github.com/parse-community/parse-server/blob/alpha/changelogs/CHANGELOG_alpha.md

ci/ciCheck.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,12 @@ async function checkMongoDbVersions() {
3030
ciEnvironmentsKeyPath: 'jobs.check-mongo.strategy.matrix.include',
3131
ciVersionKey: 'MONGODB_VERSION',
3232
releasedVersions,
33-
latestComponent: CiVersionCheck.versionComponents.path,
33+
latestComponent: CiVersionCheck.versionComponents.minor,
3434
ignoreReleasedVersions: [
3535
'<4.0.0', // Versions reached their MongoDB end-of-life support date
3636
'~4.1.0', // Development release according to MongoDB support
3737
'~4.3.0', // Development release according to MongoDB support
3838
'~4.7.0', // Development release according to MongoDB support
39-
40-
'4.0.26', // Temporarily disabled because not yet available for download via mongodb-runner
4139
],
4240
}).check();
4341
}

0 commit comments

Comments
 (0)