further investigation

Author: flovilmart

spec/Logger.spec.js

@@ -20,44 +20,44 @@ describe('Logger', () => {
     expect(Object.keys(logging.logger.transports).length).toBe(2);
   });
 
-  // xit('should have files transports', (done) => {
-  //   reconfigureServer().then(() => {
-  //     let transports = logging.logger.transports;
-  //     let transportKeys = Object.keys(transports);
-  //     expect(transportKeys.length).toBe(2);
-  //     done();
-  //   });
-  // });
+  it('should have files transports', (done) => {
+    reconfigureServer().then(() => {
+      let transports = logging.logger.transports;
+      let transportKeys = Object.keys(transports);
+      expect(transportKeys.length).toBe(2);
+      done();
+    });
+  });
 
-  // xit('should disable files logs', (done) => {
-  //   reconfigureServer({
-  //     logsFolder: null
-  //   }).then(() => {
-  //     let transports = logging.logger.transports;
-  //     let transportKeys = Object.keys(transports);
-  //     expect(transportKeys.length).toBe(0);
-  //     done();
-  //   });
-  // });
+  it('should disable files logs', (done) => {
+    reconfigureServer({
+      logsFolder: null
+    }).then(() => {
+      let transports = logging.logger.transports;
+      let transportKeys = Object.keys(transports);
+      expect(transportKeys.length).toBe(0);
+      done();
+    });
+  });
 
-  // xit('should enable JSON logs', (done) => {
-  //   // Force console transport
-  //   process.env.VERBOSE=1;
-  //   reconfigureServer({
-  //     logsFolder: null,
-  //     jsonLogs: true
-  //   }).then(() => {
-  //     let spy = spyOn(process.stdout, 'write');
-  //     logging.logger.info('hi', {key: 'value'});
-  //     expect(process.stdout.write).toHaveBeenCalled();
-  //     var firstLog = process.stdout.write.calls.first().args[0];
-  //     expect(firstLog).toEqual(JSON.stringify({key: 'value', level: 'info', message: 'hi' })+'\n');
-  //     delete process.env.VERBOSE;
-  //     return reconfigureServer({
-  //       jsonLogs: false
-  //     });
-  //   }).then(() => {
-  //     done();
-  //   });
-  // });
+  it('should enable JSON logs', (done) => {
+    // Force console transport
+    process.env.VERBOSE=1;
+    reconfigureServer({
+      logsFolder: null,
+      jsonLogs: true
+    }).then(() => {
+      let spy = spyOn(process.stdout, 'write');
+      logging.logger.info('hi', {key: 'value'});
+      expect(process.stdout.write).toHaveBeenCalled();
+      var firstLog = process.stdout.write.calls.first().args[0];
+      expect(firstLog).toEqual(JSON.stringify({key: 'value', level: 'info', message: 'hi' })+'\n');
+      delete process.env.VERBOSE;
+      return reconfigureServer({
+        jsonLogs: false
+      });
+    }).then(() => {
+      done();
+    });
+  });
 });

src/Adapters/Logger/WinstonLogger.js

@@ -14,7 +14,7 @@ function updateTransports(options) {
     if (_.isNull(options.dirname)) {
       delete transports['parse-server'];
       delete transports['parse-server-error'];
-    } else {
+    } else if (!_.isUndefined(options.dirname)) {
       transports['parse-server'] = new (DailyRotateFile)(
         Object.assign({
           filename: 'parse-server.info',